Fix 4XX errors incorrectly categorized as 5XX in PDF splitting#290
Merged
Fix 4XX errors incorrectly categorized as 5XX in PDF splitting#290
Conversation
yuming-long
approved these changes
Jul 16, 2025
Contributor
yuming-long
left a comment
yuming-long
left a comment
There was a problem hiding this comment.
LGTM! i think we only retry 5XX from retryable_codes = ["5xx"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the retry configs look like these:
retry_config = (retries, ["5xx"])retry_config = (retries, ["5xx"])retry_config = (retries, ["5xx"])retry_config = (retries, ["5xx"])retry_config = (retries, ["5xx"])retry_config = (retries, ["5xx"])This doesn't include all, but I do not see any cases where we would be retrying on a 4XX.