chore: include exception in error message#296
Merged
Conversation
ds-filipknefel
commented
Jul 21, 2025
| return response | ||
| except Exception as e: | ||
| logger.error("Request failed with error", exc_info=e) | ||
| logger.error(f"Request failed with error: {e}", exc_info=e) |
Contributor
Author
There was a problem hiding this comment.
This is the relevant change, the rest was auto formatting
awalker4
approved these changes
Jul 21, 2025
Collaborator
awalker4
left a comment
awalker4
left a comment
There was a problem hiding this comment.
LGTM! If the flapping contract test doesn't pass, we can force merge for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the exception in the error message string directly, not only via
exc_info