build: remove test and dev deps from docker image#3969
Merged
Conversation
badGarnet
reviewed
Mar 27, 2025
| ## 0.17.5 | ||
|
|
||
| ### Enhancements | ||
| - **Remove test and dev dependencies from docker image** This reduces the docker image size slightly and reduces potential security vulnerabilities. |
Collaborator
There was a problem hiding this comment.
also removed ubuntu-22 (which is out of date anyway but still good to document it)
badGarnet
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the dependencies contained in
test.txt,dev.txt, andconstraints.txtfrom the things that get installed in the docker image. In order to keep testing the image (running the tests), I added a step to thedocker-testmake target to installtest.txtanddev.txt. Thus we presumably get a smaller image (probably not much smaller), reduce the dependency chain or our images, and have less exposure to vulnerabilities while still testing as robustly as before.Incidentally, I removed the
Dockerfilefor our ubuntu image, since it made reference to non-existent make targets, which tells me it's stale and wasn't being used.Review:
pytestin the docker build and test logs, after the image build is completed.