fix: properly handle the case when an element's text is None#3995
Merged
fix: properly handle the case when an element's text is None#3995
Conversation
badGarnet
deleted the
fix/fix-chunking-with-elements-with-no-text-attribute
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some elements, like
Image, can haveNoneas itstextattribute's value. In that case current chunking logic fails because it expects the field to always have a length or can be split. The fix is to update the logic aselement.text or ""for checking length and add flow control to early exit to avoid calling split onNone.