Inconsistent behaviour between layout callvotes and map callvotes/map/devmap, resulting in map crashes

[VReaperV]

If a layout has a large number of buildings (~250), trying to do /callvote map map layout, /map map layout or /devmap map layout results in the game going back to the main menu. The log shows a warning "Warn: CL_ParseGamestate: bad command byte", used to be a warning about there being too many entities for the VM in one of the previous versions.

However, using /callvote layout layout after the map was already loaded results in the same layout loading normally.

An example layout showing this behaviour attached for map spacetracks.

humanpve1.zip

[DolceTriade]

We'll take a look. Thanks for reporting. Which map is this layout for?

[VReaperV]

spacetracks, one of the default maps (map-spacetracks_1.1.2.dpk).

Directly related to #573

[sweet235]

I suspect the following happens when we try this on a public server: the server continues to run, but every connected clients crashes. This can be tested on bot testing sk7 right now, but may put the server into an unusable state.

[sweet235]

the server continues to run, but every connected clients crashes

This is indeed the case.

[cu-kai]

spacetracks.zip

I have attached a zip containing layouts for spacetracks guaranteed to cause the crash as of 0.54 (use alienpve1-{1|2|3} when testing this)

[VReaperV]

Fixed by DaemonEngine/Daemon#1427.