Implement pedantic shutdown options for gamelogic processes

[slipher]

When g_pedanticShutdown/cg_pedanticShutdown is off (default) and the gamelogic is running in a separate process, skip shutdown code whose only purpose is to deallocate memory. This saves time and avoids spamming anyone with shutdown errors in production for cleanup issues like with Lua (#3078) or RmlUi (#1693).

[illwieckz]

Just a style remark, for this kind of code:

#ifndef BUILD_VM_IN_PROCESS
static Cvar::Cvar<bool> cg_pedanticShutdown("cg_pedanticShutdown",
	"run useless shutdown procedures in cgame process",
	Cvar::NONE,
#ifdef USING_SANITIZER
	true);
#else
	false);
#endif
#endif

I prefer it written this way (no preprocessor in the middle of something):

#ifndef BUILD_VM_IN_PROCESS
#ifdef USING_SANITIZER
static const bool defaultPedanticShutdown = true;
#else
static const bool defaultPedanticShutdown = false;
#endif
static Cvar::Cvar<bool> cg_pedanticShutdown("cg_pedanticShutdown",
	"run useless shutdown procedures in cgame process",
	Cvar::NONE, defaultPedanticShutdown);
#endif

…and even GitHub syntax coloring prefers it as well.

See also:

• bikeshedding: make syntax coloring happier DaemonEngine/Daemon#1226

At the time I also noticed that VIM also prefers it that way.

And outside of coloring, this makes easier to read the code.

[slipher]

Personally my reaction is that those syntax highlighters should git gud. But I will do it if you give me LGTM modulo the style comment 😛

[illwieckz]

Personally my reaction is that those syntax highlighters should git gud. But I will do it if you give me LGTM modulo the style comment 😛

Is this blackmail? 😛

LGTM modulo the style comment anyway, that syntax is the only thing I have something to say against.

[illwieckz]

LGTM modulo the style.

[illwieckz]

Note that my new lines in my examples are not part of my recommendation, it's just to workaroud GitHub not wrapping lines and keep my comments readable.

This is fine:

#ifndef BUILD_VM_IN_PROCESS
#ifdef USING_SANITIZER
static const bool defaultPedanticShutdown = true;
#else
static const bool defaultPedanticShutdown = false;
#endif
static Cvar::Cvar<bool> cg_pedanticShutdown("cg_pedanticShutdown", "run useless shutdown procedures in cgame process", Cvar::NONE, defaultPedanticShutdown);
#endif // !BUILD_VM_IN_PROCESS

[sweet235]

I guess every second spent on thinking about Github's current code rendering is a waste of human resources.

[DolceTriade]

fwiw, my human brain also prefers:

#ifndef BUILD_VM_IN_PROCESS
#ifdef USING_SANITIZER
static const bool defaultPedanticShutdown = true;
#else
static const bool defaultPedanticShutdown = false;
#endif
static Cvar::Cvar<bool> cg_pedanticShutdown("cg_pedanticShutdown",
	"run useless shutdown procedures in cgame process",
	Cvar::NONE, defaultPedanticShutdown);
#endif

otherwise, lgtm % style nit