Cleanup CUDA implementation a bit#199
Closed
gonzalobg wants to merge 6 commits into
Closed
Conversation
gonzalobg
commented
May 30, 2024
gonzalobg
commented
Contributor
- Refactor all kernels into a generic "parallel for" algorithm
- Supports grid-stride and block-stride loops, configurable with model flag
- Handles devices of different sizes via occupancy APIs
- Refactor memory allocation APIs
- Prints more GPU details, in particular, the theoretical peak BW in GB/s of the current device, using the NVML library (which is part of the CUDA Toolkit and always available)
- Fixes 2 bugs:
- Prints the "order" used to run the benchmarks (e.g. classic vs isolated)
- Fixes a division by zero bug in the solution checking
Contributor
Author
|
This was passing. Seems like this and other PRs are spuriously failing due to some cache issue @tom91136 @tomdeakin |
Contributor
Author
|
Closing for #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.