fix: update code to solve clippy issues

Author: henrybarreto

updatehub-cloud-sdk/src/api.rs

@@ -3,6 +3,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use serde::Serialize;
+use std::fmt::Write;
 use std::{collections::BTreeMap, fs, path::Path};
 
 #[derive(Debug)]
@@ -33,7 +34,7 @@ pub struct FirmwareMetadata<'a> {
 
 pub struct MetadataValue<'a>(pub &'a BTreeMap<String, Vec<String>>);
 
-impl<'a> serde::ser::Serialize for MetadataValue<'a> {
+impl serde::ser::Serialize for MetadataValue<'_> {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: serde::ser::Serializer,
@@ -59,7 +60,11 @@ impl UpdatePackage {
     }
 
     pub fn package_uid(&self) -> String {
-        openssl::sha::sha256(&self.raw).iter().map(|c| format!("{:02x}", c)).collect()
+        openssl::sha::sha256(&self.raw).iter().fold(String::new(), |mut output, c| {
+            let _ = write!(output, "{c:02X}");
+
+            output
+        })
     }
 
     pub fn version(&self) -> &str {

updatehub-cloud-sdk/src/client.rs

@@ -85,7 +85,7 @@ impl<'a> Client<'a> {
 
         let response = self
             .client
-            .post(&format!("{}/upgrades", &self.server))
+            .post(format!("{}/upgrades", &self.server))
             .header("api-retries", num_retries.to_string())
             .json(&firmware)
             .send()
@@ -181,7 +181,7 @@ impl<'a> Client<'a> {
         let payload =
             Payload { state, firmware, package_uid, previous_state, error_message, current_log };
 
-        self.client.post(&format!("{}/report", &self.server)).json(&payload).send().await?;
+        self.client.post(format!("{}/report", &self.server)).json(&payload).send().await?;
         Ok(())
     }
 }

updatehub-sdk/src/api/info/firmware.rs

@@ -125,7 +125,7 @@ impl<'de> Deserialize<'de> for MetadataValue {
     }
 }
 
-impl<'a> Index<&'a str> for MetadataValue {
+impl Index<&str> for MetadataValue {
     type Output = Vec<String>;
 
     #[inline]

updatehub-sdk/src/client.rs

@@ -43,7 +43,7 @@ impl Client {
     /// This method fails when cannot complete the request at the address or
     /// cannot parse the body json as a `info::Response`.
     pub async fn info(&self) -> Result<api::info::Response> {
-        let response = self.client.get(&format!("{}/info", self.server_address)).send().await?;
+        let response = self.client.get(format!("{}/info", self.server_address)).send().await?;
 
         match response.status() {
             StatusCode::OK => Ok(response.json().await?),
@@ -110,7 +110,7 @@ impl Client {
     pub async fn local_install(&self, file: &Path) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/local_install", self.server_address))
+            .post(format!("{}/local_install", self.server_address))
             .json(&api::local_install::Request { file: file.to_owned() })
             .send()
             .await?;
@@ -139,7 +139,7 @@ impl Client {
     pub async fn remote_install(&self, url: &str) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/remote_install", self.server_address))
+            .post(format!("{}/remote_install", self.server_address))
             .json(&api::remote_install::Request { url: url.to_owned() })
             .send()
             .await?;
@@ -167,7 +167,7 @@ impl Client {
     pub async fn abort_download(&self) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/update/download/abort", self.server_address))
+            .post(format!("{}/update/download/abort", self.server_address))
             .send()
             .await?;
 
@@ -193,7 +193,7 @@ impl Client {
     /// This method fails when cannot complete the request at the address or
     /// cannot parse the body json as a `log::Log`.
     pub async fn log(&self) -> Result<api::log::Log> {
-        let response = self.client.get(&format!("{}/log", self.server_address)).send().await?;
+        let response = self.client.get(format!("{}/log", self.server_address)).send().await?;
 
         match response.status() {
             StatusCode::OK => Ok(response.json().await?),

updatehub-sdk/src/listener.rs

@@ -103,7 +103,7 @@ impl StateChange {
         F: Fn(Handler) -> Fut + 'static,
         Fut: Future<Output = Result<()>> + 'static,
     {
-        self.callbacks.entry(state).or_insert_with(Vec::new).push(Box::new(move |d| Box::pin(f(d))))
+        self.callbacks.entry(state).or_default().push(Box::new(move |d| Box::pin(f(d))))
     }
 
     /// Start the agent to listen for messages on the socket.

updatehub/src/firmware/tests.rs

@@ -124,7 +124,8 @@ pub(crate) fn create_fake_starup_callbacks(metadata_dir: &Path, output_file: &Pa
         let mut file = fs::OpenOptions::new()
             .write(true)
             .create(true)
-            .open(&metadata_dir.join(script))
+            .truncate(true)
+            .open(metadata_dir.join(script))
             .unwrap();
         writeln!(file, "#!/bin/sh\necho $0 >> {}", output_file.to_string_lossy()).unwrap();
         let mut permissions = fs::metadata(metadata_dir).unwrap().permissions();

updatehub/src/mem_drain.rs

@@ -49,6 +49,7 @@ impl Serialize for MemDrain {
     }
 }
 
+#[allow(clippy::to_string_trait_impl)]
 impl ToString for MemDrain {
     fn to_string(&self) -> String {
         let records = self.records.read().unwrap();

updatehub/src/object/installer/imxkobs.rs

@@ -25,11 +25,8 @@ impl Installer for objects::Imxkobs {
 
         let should_skip_install =
             super::should_skip_install(&self.install_if_different, &self.sha256sum, async {
-                let path = self
-                    .chip_0_device_path
-                    .as_ref()
-                    .map(PathBuf::clone)
-                    .unwrap_or_else(|| PathBuf::from("/dev/mtd0"));
+                let path =
+                    self.chip_0_device_path.clone().unwrap_or_else(|| PathBuf::from("/dev/mtd0"));
                 let f = path.file_name().ok_or(Error::InvalidPath)?;
                 let mut file_name = f.to_os_string();
                 file_name.push("ro");

updatehub/src/runtime_settings.rs

@@ -103,7 +103,7 @@ impl RuntimeSettings {
                 .map(|s| RuntimeSettings { inner: s, v1_content: Some(content.to_string()) })
         });
 
-        runtime_settings.map_err(Error::from)
+        runtime_settings
     }
 
     fn save(&self) -> Result<()> {

updatehub/src/tests.rs

@@ -164,7 +164,7 @@ impl TestEnvironmentBuilder {
             }
 
             for bin in self.extra_binaries.into_iter() {
-                let mut file = fs::File::create(&bin_dir_path.join(&bin)).unwrap();
+                let mut file = fs::File::create(bin_dir_path.join(&bin)).unwrap();
                 writeln!(file, "#!/bin/sh\necho {} $@ >> {}", bin, output_file.to_string_lossy())
                     .unwrap();
                 let mut permissions = file.metadata().unwrap().permissions();