fix: update code to solve clippy issues

Author: henrybarreto

updatehub-cloud-sdk/src/api.rs

@@ -3,7 +3,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use serde::Serialize;
-use std::{collections::BTreeMap, fs, path::Path};
+use std::{collections::BTreeMap, fmt::Write, fs, path::Path};
 
 #[derive(Debug)]
 pub enum ProbeResponse {
@@ -33,7 +33,7 @@ pub struct FirmwareMetadata<'a> {
 
 pub struct MetadataValue<'a>(pub &'a BTreeMap<String, Vec<String>>);
 
-impl<'a> serde::ser::Serialize for MetadataValue<'a> {
+impl serde::ser::Serialize for MetadataValue<'_> {
     fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: serde::ser::Serializer,
@@ -59,7 +59,11 @@ impl UpdatePackage {
     }
 
     pub fn package_uid(&self) -> String {
-        openssl::sha::sha256(&self.raw).iter().map(|c| format!("{:02x}", c)).collect()
+        openssl::sha::sha256(&self.raw).iter().fold(String::new(), |mut output, c| {
+            let _ = write!(output, "{c:02x}");
+
+            output
+        })
     }
 
     pub fn version(&self) -> &str {

updatehub-cloud-sdk/src/client.rs

@@ -85,7 +85,7 @@ impl<'a> Client<'a> {
 
         let response = self
             .client
-            .post(&format!("{}/upgrades", &self.server))
+            .post(format!("{}/upgrades", &self.server))
             .header("api-retries", num_retries.to_string())
             .json(&firmware)
             .send()
@@ -181,7 +181,7 @@ impl<'a> Client<'a> {
         let payload =
             Payload { state, firmware, package_uid, previous_state, error_message, current_log };
 
-        self.client.post(&format!("{}/report", &self.server)).json(&payload).send().await?;
+        self.client.post(format!("{}/report", &self.server)).json(&payload).send().await?;
         Ok(())
     }
 }

updatehub-cloud-sdk/src/lib.rs

@@ -24,10 +24,10 @@ pub enum Error {
     ParseInt(std::num::ParseIntError),
 
     Http(reqwest::Error),
-    #[display(fmt = "Invalid status response: {}", _0)]
+    #[display(fmt = "Invalid status response: {_0}")]
     InvalidStatusResponse(#[error(not(source))] reqwest::StatusCode),
-    #[display(fmt = "Invalid header value: {}", _0)]
+    #[display(fmt = "Invalid header value: {_0}")]
     HeaderParse(reqwest::header::ToStrError),
-    #[display(fmt = "Invalid url: {}", _0)]
+    #[display(fmt = "Invalid url: {_0}")]
     UrlParse(url::ParseError),
 }

updatehub-cloud-sdk/tests/integration_test.rs

@@ -243,7 +243,7 @@ async fn probe_response_with_signature() {
                 .unwrap()
         ),
         ProbeResponse::Update(_, None) => panic!("No signature extracted from update response"),
-        r => panic!("Unexpected probe response: {:?}", r),
+        r => panic!("Unexpected probe response: {r:?}"),
     }
     mocks.assert();
 }
@@ -256,7 +256,7 @@ async fn probe_response_with_extra_poll() {
         sdk::Client::new(&server.url()).probe(0, FakeMetadata::new().get()).await.unwrap();
     match response {
         ProbeResponse::ExtraPoll(n) => assert_eq!(n, 10),
-        r => panic!("Unexpected probe response: {:?}", r),
+        r => panic!("Unexpected probe response: {r:?}"),
     }
     mocks.assert();
 }

updatehub-package-schema/src/definitions/chunk_size.rs

@@ -24,7 +24,7 @@ impl<'de> Deserialize<'de> for ChunkSize {
         if n > 1 {
             return Ok(ChunkSize(n));
         }
-        Err(de::Error::custom(format!("Invalid chunk size: {}", n)))
+        Err(de::Error::custom(format!("Invalid chunk size: {n}")))
     }
 }
 

updatehub-package-schema/src/definitions/count.rs

@@ -22,7 +22,7 @@ impl<'de> Deserialize<'de> for Count {
         match isize::deserialize(deserializer)? {
             -1 => Ok(Count::All),
             n if n >= 0 => Ok(Count::Limited(n)),
-            n => Err(de::Error::custom(format!("Invalid count: {}", n))),
+            n => Err(de::Error::custom(format!("Invalid count: {n}"))),
         }
     }
 }

updatehub-package-schema/src/definitions/install_if_different.rs

@@ -14,7 +14,7 @@ pub enum InstallIfDifferent {
     #[display(fmt = "checksum")]
     CheckSum,
     /// Use a predefined (known) pattern to check.
-    #[display(fmt = "pattern({} equal to '{}')", pattern, version)]
+    #[display(fmt = "pattern({pattern} equal to '{version}')")]
     KnownPattern { version: String, pattern: KnownPatternKind },
     /// Use a custom pattern to check.
     #[display(fmt = "custom pattern({} uqual to '{}')", "pattern.regexp", version)]
@@ -50,7 +50,7 @@ where
 {
     match String::deserialize(deserializer)?.to_lowercase().as_str() {
         "sha256sum" => Ok(()),
-        s => Err(serde::de::Error::custom(format!("Not a vliad CheckSum format: {}", s))),
+        s => Err(serde::de::Error::custom(format!("Not a vliad CheckSum format: {s}"))),
     }
 }
 

updatehub-sdk/src/api/info/firmware.rs

@@ -125,7 +125,7 @@ impl<'de> Deserialize<'de> for MetadataValue {
     }
 }
 
-impl<'a> Index<&'a str> for MetadataValue {
+impl Index<&str> for MetadataValue {
     type Output = Vec<String>;
 
     #[inline]

updatehub-sdk/src/api/mod.rs

@@ -140,7 +140,7 @@ pub mod log {
     impl core::fmt::Display for Log {
         fn fmt(&self, f: &mut core::fmt::Formatter) -> Result<(), core::fmt::Error> {
             for entry in &self.entries {
-                writeln!(f, "{}", entry)?;
+                writeln!(f, "{entry}")?;
             }
             Ok(())
         }

updatehub-sdk/src/client.rs

@@ -25,7 +25,7 @@ impl Default for Client {
 impl Client {
     /// Constructs a new `Client`.
     pub fn new(server_address: &str) -> Self {
-        Client { server_address: format!("http://{}", server_address), ..Self::default() }
+        Client { server_address: format!("http://{server_address}"), ..Self::default() }
     }
 
     /// Get the current state of the agent.
@@ -43,7 +43,7 @@ impl Client {
     /// This method fails when cannot complete the request at the address or
     /// cannot parse the body json as a `info::Response`.
     pub async fn info(&self) -> Result<api::info::Response> {
-        let response = self.client.get(&format!("{}/info", self.server_address)).send().await?;
+        let response = self.client.get(format!("{}/info", self.server_address)).send().await?;
 
         match response.status() {
             StatusCode::OK => Ok(response.json().await?),
@@ -110,7 +110,7 @@ impl Client {
     pub async fn local_install(&self, file: &Path) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/local_install", self.server_address))
+            .post(format!("{}/local_install", self.server_address))
             .json(&api::local_install::Request { file: file.to_owned() })
             .send()
             .await?;
@@ -139,7 +139,7 @@ impl Client {
     pub async fn remote_install(&self, url: &str) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/remote_install", self.server_address))
+            .post(format!("{}/remote_install", self.server_address))
             .json(&api::remote_install::Request { url: url.to_owned() })
             .send()
             .await?;
@@ -167,7 +167,7 @@ impl Client {
     pub async fn abort_download(&self) -> Result<api::state::Response> {
         let response = self
             .client
-            .post(&format!("{}/update/download/abort", self.server_address))
+            .post(format!("{}/update/download/abort", self.server_address))
             .send()
             .await?;
 
@@ -193,7 +193,7 @@ impl Client {
     /// This method fails when cannot complete the request at the address or
     /// cannot parse the body json as a `log::Log`.
     pub async fn log(&self) -> Result<api::log::Log> {
-        let response = self.client.get(&format!("{}/log", self.server_address)).send().await?;
+        let response = self.client.get(format!("{}/log", self.server_address)).send().await?;
 
         match response.status() {
             StatusCode::OK => Ok(response.json().await?),