Skip to content

Commit 42404cd

Browse files
authored
fix(mcp): register or remove dead agentic tool imports (B11) (#16)
Three agentic tools were imported but never added to the served tools array, making them unreachable dead code: convene_llm_council and draft_care_action (src/tools/actions.ts) and generate_pas_payload (src/tools/da_vinci.ts). The adding commits stopped short of the array, shipped no tests, no CHANGELOG, and no README — staged-but-unfinished, not finished-and-forgotten. Removed rather than registered: convene_llm_council and draft_care_action forward to upstream-data endpoints that call frontier LLMs through OpenRouter (no HIPAA BAA), and the council endpoint runs no DLP scrub on its input, so exposing them on a public MCP client would re-open the PHI boundary the dataset tools were re-derived to close. git history retains the source if a properly bounded, tested version is wired in later.
1 parent 2024433 commit 42404cd

4 files changed

Lines changed: 12 additions & 77 deletions

File tree

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2626
paths move from `/api/v1/data/packs/{id}/*` to
2727
`/api/v1/data/catalog/{dataset_id}/*`.
2828

29+
### Removed
30+
31+
- **Three unfinished agentic tools removed before any release** (`convene_llm_council`,
32+
`draft_care_action`, `generate_pas_payload`). They were imported but never added to the
33+
served tools array, shipped without tests, CHANGELOG, or README, and were unreachable as
34+
dead code. Two of them (`convene_llm_council`, `draft_care_action`) forward to the
35+
upstream-data `/api/v1/score/council` and `/api/v1/actions/draft` endpoints, which call
36+
frontier LLMs through OpenRouter — a provider with no HIPAA BAA — and the council endpoint
37+
performs no DLP scrub on its input, so exposing them on a public MCP client would re-open
38+
the PHI boundary the dataset tools were re-derived to close. Removed rather than registered;
39+
git history retains the source if a properly bounded, tested version is wired in later.
40+
2941
### Added
3042

3143
- `UpstreamClientConfig` + `UPSTREAM_DATA_CONFIG`: the hardened API client is now

src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {
3434
import { getDentalPayerDrift } from './tools/get_dental_payer_drift.js';
3535
import { getBenchmarkHistory, getBenchmarkLeaderboard, getModelScores } from './tools/benchmark.js';
3636
import { getBenchmarkReport, runBenchmark, scoreClaim, synthesizeClaims } from './tools/claims.js';
37-
import { conveneLlmCouncil, draftCareAction } from './tools/actions.js';
3837

3938
type ToolDefinition = {
4039
name: string;

src/tools/actions.ts

Lines changed: 0 additions & 50 deletions
This file was deleted.

src/tools/da_vinci.ts

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)