docs(codereview): add logging level rules#158
Merged
sohil-kshirsagar merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Mirror the logging-level guardrail added to the python SDK's BUGBOT (Use-Tusk/drift-python-sdk#95). The python SDK had shipped per-connect and per-request INFO logs that flooded customer output; this SDK's instrumentations are currently clean, but the default log level is "info" and the risk is the same. Adding the rules now so future instrumentations don't regress.
sohankshirsagar
approved these changes
Apr 21, 2026
Contributor
Code ReviewTusk Review: No issues foundUnit TestsNo tests generatedNo symbols were selected for unit test generation because the changes are limited to updates in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Mirror the logging-level guardrail added to the python SDK's code review guidelines (drift-python-sdk#95) so the same class of bug can't ship here either.