chore: use JsonSchema proto#25
Merged
Merged
Conversation
9 tasks
jy-tan
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to use the new
JsonSchemaproto in SDK.Corresponding PR in
drift-schemaswith release TODOs: Use-Tusk/tusk-drift-schemas#11Other updates:
tsconfig.jsonso we get build errors in tests. This won't show up in our build because oftsdown.config.tsNote that empty
propertiesmap required for all schemasProto3 doesn't support optional maps, so every
JsonSchemamust have apropertiesfield:Impact: Slightly larger JSON payloads, but acceptable trade-off for type safety. I couldn't find a way around this.
Note
Switches SDK to proto-based JsonSchema types, passes schemas natively in protobuf, updates tests/HTTP utils accordingly, and enables test files in typecheck.
JsonSchemaType/EncodingType/DecodedType/JsonSchemawith proto types from@use-tusk/drift-schemas/core/json_schema; re-export where needed.inputSchema/outputSchemaas protoJsonSchema(notoStruct) inProtobufCommunicatorandApiSpanAdapter.properties: {}; adjust array/Set handling.CleanSpanDatato use protoJsonSchema(makeoutputSchemaoptional).HttpBodyType;getDecodedTypenow returns protoDecodedType.properties: {}in schemas.@use-tusk/drift-schemasto^0.1.11.Written by Cursor Bugbot for commit 6bde6fd. This will update automatically on new commits. Configure here.