Skip to content

chore: fix publish#30

Merged
sohil-kshirsagar merged 1 commit into
mainfrom
sohil/fix-publish
Oct 14, 2025
Merged

chore: fix publish#30
sohil-kshirsagar merged 1 commit into
mainfrom
sohil/fix-publish

Conversation

@sohil-kshirsagar

@sohil-kshirsagar sohil-kshirsagar commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Note

Removes the Run tests step from the NPM publish GitHub Actions workflow.

  • CI/CD:
    • In .github/workflows/publish.yml, remove the Run tests step from the publish job, keeping install, build, and publish steps.

Written by Cursor Bugbot for commit 8712783. This will update automatically on new commits. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Publish Workflow Skips Critical Testing Step

The publish workflow no longer runs tests before publishing packages to NPM. This removes a critical quality gate, allowing potentially broken or untested code to be distributed to users.

.github/workflows/publish.yml#L25-L35

- name: Install dependencies
run: npm ci
- name: Build
run: npm run build
- name: Publish to NPM registry
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm publish

Fix in Cursor Fix in Web


@sohil-kshirsagar sohil-kshirsagar merged commit 9bf2af8 into main Oct 14, 2025
3 checks passed
@sohil-kshirsagar sohil-kshirsagar deleted the sohil/fix-publish branch October 14, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants