Skip to content

chore: add cache-busting to e2e tests and improve mysql2 base connection support#33

Merged
sohankshirsagar merged 4 commits into
mainfrom
sohan/misc-updates
Oct 15, 2025
Merged

chore: add cache-busting to e2e tests and improve mysql2 base connection support#33
sohankshirsagar merged 4 commits into
mainfrom
sohan/misc-updates

Conversation

@sohankshirsagar

@sohankshirsagar sohankshirsagar commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Note

Broaden mysql2 instrumentation to support >=2.3.3<4.0.0 with version-aware patching and update tests, plus add cache-busting to e2e Dockerfiles and minor logging/docs tweaks.

  • Instrumentation (mysql2):
    • Expand support to >=2.3.3 <4.0.0 with version-aware patching of connection, base/connection, pool, and pool_connection.
    • Refactor into helpers for prototype/class wrapping; skip redundant patches for v3 base.
    • Maintain create functions patching (mysql2/lib/create_connection.js, create_pool.js).
  • Tests:
    • Update integration tests to expect mysql2.connection.query spans (vs poolConnection.query), adjust assertions/formatting.
    • Change cjs-mysql2 test app mysql2 dep to ^3.9.8.
  • E2E Dockerfiles:
    • Add ARG CACHEBUST=1 to multiple e2e images (fetch, http, grpc, ioredis, mysql2, pg, postgres) to force fresh CLI download.
  • Other:
    • Minor log/constant tweaks in http and ioredis instrumentation; add debug log for replay trace id; string style normalization.
    • Docs: retitle docs/nextjs-initialization.md to “Next.js Initialization (Beta)”.
    • Small formatting/quote updates (e.g., schema helper, docker-compose).

Written by Cursor Bugbot for commit aa7c508. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

Comment thread src/instrumentation/libraries/mysql2/Instrumentation.ts
@sohankshirsagar sohankshirsagar merged commit 843811a into main Oct 15, 2025
3 checks passed
@sohankshirsagar sohankshirsagar deleted the sohan/misc-updates branch October 15, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants