Skip to content

Commit 01a0b3a

Browse files
ref: remove proto re-exports from types.py, import directly from tusk.drift.core.v1
types.py now only contains SDK wrapper dataclasses and utility functions. Proto types are imported directly where used. Removes SDKMessageType/CLIMessageType aliases.
1 parent 97d824e commit 01a0b3a

3 files changed

Lines changed: 17 additions & 55 deletions

File tree

drift/core/communication/__init__.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,25 @@
66

77
from .communicator import CommunicatorConfig, ProtobufCommunicator
88
from .types import (
9-
CliMessage,
10-
CLIMessageType,
119
ConnectRequest,
1210
ConnectResponse,
1311
GetMockRequest,
1412
GetMockResponse,
15-
MessageType,
1613
MockRequestInput,
1714
MockResponseOutput,
18-
# Protobuf types (re-exported)
19-
SdkMessage,
20-
SDKMessageType,
2115
dict_to_span,
2216
extract_response_data,
2317
span_to_proto,
2418
)
2519

2620
__all__ = [
27-
# Message types
28-
"MessageType",
29-
"SDKMessageType",
30-
"CLIMessageType",
3121
# Request/Response types
3222
"ConnectRequest",
3323
"ConnectResponse",
3424
"GetMockRequest",
3525
"GetMockResponse",
3626
"MockRequestInput",
3727
"MockResponseOutput",
38-
# Protobuf types
39-
"SdkMessage",
40-
"CliMessage",
4128
# Utilities
4229
"span_to_proto",
4330
"dict_to_span",

drift/core/communication/communicator.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,31 @@
1010
from dataclasses import dataclass
1111
from typing import Any
1212

13-
from tusk.drift.core.v1 import GetMockRequest as ProtoGetMockRequest
14-
15-
from ...version import MIN_CLI_VERSION, SDK_VERSION
16-
from ..span_serialization import clean_span_to_proto
17-
from ..types import CleanSpanData, calling_library_context
18-
from .types import (
13+
from tusk.drift.core.v1 import (
1914
BranchInfo,
2015
CliMessage,
21-
ConnectRequest,
2216
CoverageSnapshotResponse,
2317
FileCoverageData,
24-
GetMockRequest,
2518
InstrumentationVersionMismatchAlert,
2619
MessageType,
27-
MockRequestInput,
28-
MockResponseOutput,
2920
SdkMessage,
3021
SendAlertRequest,
3122
SendInboundSpanForReplayRequest,
3223
SetTimeTravelResponse,
3324
UnpatchedDependencyAlert,
25+
)
26+
from tusk.drift.core.v1 import (
27+
GetMockRequest as ProtoGetMockRequest,
28+
)
29+
30+
from ...version import MIN_CLI_VERSION, SDK_VERSION
31+
from ..span_serialization import clean_span_to_proto
32+
from ..types import CleanSpanData, calling_library_context
33+
from .types import (
34+
ConnectRequest,
35+
GetMockRequest,
36+
MockRequestInput,
37+
MockResponseOutput,
3438
span_to_proto,
3539
)
3640

drift/core/communication/types.py

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,6 @@
1212
from __future__ import annotations
1313

1414
__all__ = [
15-
# Re-exported protobuf types
16-
"CliMessage",
17-
"InstrumentationVersionMismatchAlert",
18-
"MessageType",
19-
"Runtime",
20-
"SdkMessage",
21-
"SendAlertRequest",
22-
"SendInboundSpanForReplayRequest",
23-
"SetTimeTravelRequest",
24-
"SetTimeTravelResponse",
25-
"UnpatchedDependencyAlert",
26-
# Aliases
27-
"SDKMessageType",
28-
"CLIMessageType",
2915
# Dataclasses
3016
"ConnectRequest",
3117
"ConnectResponse",
@@ -42,21 +28,6 @@
4228
from dataclasses import dataclass, field
4329
from typing import Any
4430

45-
from tusk.drift.core.v1 import (
46-
BranchInfo, # noqa: F401 (re-exported)
47-
CliMessage,
48-
CoverageSnapshotResponse, # noqa: F401 (re-exported)
49-
FileCoverageData, # noqa: F401 (re-exported)
50-
InstrumentationVersionMismatchAlert,
51-
MessageType,
52-
Runtime,
53-
SdkMessage,
54-
SendAlertRequest,
55-
SendInboundSpanForReplayRequest,
56-
SetTimeTravelRequest,
57-
SetTimeTravelResponse,
58-
UnpatchedDependencyAlert,
59-
)
6031
from tusk.drift.core.v1 import (
6132
ConnectRequest as ProtoConnectRequest,
6233
)
@@ -69,6 +40,9 @@
6940
from tusk.drift.core.v1 import (
7041
GetMockResponse as ProtoGetMockResponse,
7142
)
43+
from tusk.drift.core.v1 import (
44+
Runtime,
45+
)
7246
from tusk.drift.core.v1 import (
7347
Span as ProtoSpan,
7448
)
@@ -82,9 +56,6 @@
8256
StatusCode as ProtoStatusCode,
8357
)
8458

85-
SDKMessageType = MessageType
86-
CLIMessageType = MessageType
87-
8859

8960
def _python_to_value(value: Any) -> Any:
9061
"""Convert Python value to protobuf Value."""

0 commit comments

Comments
 (0)