Skip to content

refactor: use shared test utils in urllib3 and aiohttp e2e tests #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sohankshirsagar merged 1 commit into from
Jan 16, 2026
Merged

refactor: use shared test utils in urllib3 and aiohttp e2e tests #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions drift/instrumentation/aiohttp/e2e-tests/src/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,6 @@
"""Execute test requests against the Flask app to exercise the aiohttp instrumentation."""

import time

import requests

BASE_URL = "http://localhost:8000"


def make_request(method, endpoint, **kwargs):
"""Make HTTP request and log result."""
url = f"{BASE_URL}{endpoint}"
print(f"-> {method} {endpoint}")

# Set default timeout if not provided
kwargs.setdefault("timeout", 30)
response = requests.request(method, url, **kwargs)
print(f" Status: {response.status_code}")
time.sleep(0.5) # Small delay between requests
return response

from drift.instrumentation.e2e_common.test_utils import make_request, print_request_summary

if __name__ == "__main__":
print("Starting test request sequence for aiohttp instrumentation...\n")
Expand Down Expand Up @@ -106,4 +88,4 @@ def make_request(method, endpoint, **kwargs):
# POST with bytes body
make_request("POST", "/test/post-bytes")

print("\nAll requests completed successfully")
print_request_summary()
22 changes: 2 additions & 20 deletions drift/instrumentation/urllib3/e2e-tests/src/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,6 @@
"""Execute test requests against the Flask app to exercise the urllib3 instrumentation."""

import time

import requests

BASE_URL = "http://localhost:8000"


def make_request(method, endpoint, **kwargs):
"""Make HTTP request and log result."""
url = f"{BASE_URL}{endpoint}"
print(f"-> {method} {endpoint}")

# Set default timeout if not provided
kwargs.setdefault("timeout", 30)
response = requests.request(method, url, **kwargs)
print(f" Status: {response.status_code}")
time.sleep(0.5) # Small delay between requests
return response

from drift.instrumentation.e2e_common.test_utils import make_request, print_request_summary

if __name__ == "__main__":
print("Starting test request sequence for urllib3 instrumentation...\n")
Expand Down Expand Up @@ -127,4 +109,4 @@ def make_request(method, endpoint, **kwargs):
# curl http://localhost:8000/test/bug/streaming-response
# ==========================================================================

print("\nAll requests completed successfully")
print_request_summary()