Skip to content

test: improve coverage for core logic #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jy-tan merged 9 commits into from
Jan 18, 2026
Merged

test: improve coverage for core logic #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5932dbf
Commit
jy-tan Jan 18, 2026
eb6cc52
Fix flaky test
jy-tan Jan 18, 2026
e29590b
Try using xml
jy-tan Jan 18, 2026
2828df3
Try this
jy-tan Jan 18, 2026
73a426f
Try this
jy-tan Jan 18, 2026
a0f68cf
Dumps
jy-tan Jan 18, 2026
b4588d3
Debug
jy-tan Jan 18, 2026
1ac1615
Fix
jy-tan Jan 18, 2026
8bae34f
Cleanup
jy-tan Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ jobs:
test:
name: Unit Tests (Python ${{ matrix.python-version }})
runs-on: ubuntu-latest
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.14"]
steps:
Expand All @@ -70,11 +72,31 @@ jobs:
- name: Setup Python
run: uv python install ${{ matrix.python-version }}

- name: Cache uv + Python installs + venv
uses: actions/cache@v4
with:
path: |
~/.cache/uv
~/.local/share/uv/python
.venv
key: ${{ runner.os }}-uv-${{ matrix.python-version }}-${{ hashFiles('uv.lock') }}

- name: Install dependencies
run: uv sync --all-extras

- name: Run unit tests
run: uv run pytest tests/unit/ -v
if: matrix.python-version != '3.9'
run: uv run pytest tests/unit/ -q

- name: Run unit tests with coverage
if: matrix.python-version == '3.9'
run: uv run pytest tests/unit/ -q --cov=drift/core --cov-report=xml

- name: Upload coverage to Coveralls
if: matrix.python-version == '3.9' && github.event_name == 'push' && github.ref == 'refs/heads/main'
uses: coverallsapp/github-action@v2
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Jan 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Coveralls uploads run for each matrix job without parallel build configuration, so Coveralls will treat each upload as a separate build and coverage can be incomplete or overwritten. Configure parallel: true + flag-name on the matrix step and add a parallel-finished job to close/aggregate the build.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/ci.yml, line 81:

<comment>Coveralls uploads run for each matrix job without parallel build configuration, so Coveralls will treat each upload as a separate build and coverage can be incomplete or overwritten. Configure `parallel: true` + `flag-name` on the matrix step and add a `parallel-finished` job to close/aggregate the build.</comment>

<file context>
@@ -73,8 +73,12 @@ jobs:
+
+      - name: Upload coverage to Coveralls
+        # if: matrix.python-version == '3.9' && github.event_name == 'push' && github.ref == 'refs/heads/main'
+        uses: coverallsapp/github-action@v2
 
   build:
</file context>
Fix with Cubic

Copy link
Copy Markdown
Contributor Author

@jy-tan jy-tan Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer valid

with:
file: coverage.xml

build:
name: Build Package
Expand Down
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,9 @@ __marimo__/
.DS_Store

# Bug tracking
**/BUG_TRACKING.md
**/BUG_TRACKING.md

# Coverage
coverage.lcov
coverage.xml
.coverage
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ uv run ty check drift/ tests/ # Type check
```bash
uv run pytest tests/unit/ -v

# Run with coverage
uv run pytest tests/unit/ -v --cov=drift --cov-report=term-missing

# Run a specific test file
uv run pytest tests/unit/test_json_schema_helper.py -v
uv run pytest tests/unit/test_adapters.py -v
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ dev = [
"ty>=0.0.1a7",
"pytest>=8.0.0,<9.0.0",
"pytest-mock>=3.15.0",
"pytest-cov>=7.0.0",
]

[project.urls]
Expand Down
Loading