fix: support microseconds and timezone offsets in timestamp ignore regex#200
Merged
sohankshirsagar merged 1 commit intomainfrom Mar 19, 2026
Merged
fix: support microseconds and timezone offsets in timestamp ignore regex#200sohankshirsagar merged 1 commit intomainfrom
sohankshirsagar merged 1 commit intomainfrom
Conversation
Contributor
Generated 8 tests - 8 passedTip New to Tusk Unit Tests? Learn more here. You are using "Only surface failing tests" mode, so Tusk will only surface failing tests in the PR comment but you can still see any passing tests in the Tusk UI. Considered 8 test scenarios and 1 symbol in 1 file but found no failing tests. View check history
Was Tusk helpful? Give feedback by reacting with 👍 or 👎 |
sohil-kshirsagar
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The built-in
ignore_timestampsregex only matched ISO 8601 timestamps with exactly 3 fractional-second digits and an optionalZsuffix. Timestamps with microsecond precision (6 digits) or numeric timezone offsets like+00:00were not recognized, causing false deviations during drift runs.Changes
timestampRegexindynamic_fields.goto accept any number of fractional-second digits (\.\d+instead of\.\d{3}) and bothZand±HH:MMtimezone offsets ((Z|[+-]\d{2}:\d{2})?instead ofZ?)dynamic_fields_test.gocovering microseconds with+00:00, microseconds withZ, non-UTC offsets (+05:30,-04:00), and milliseconds with offsets