Skip to content

Commit 39e7122

Browse files
committed
Install Playwright browsers via e2e's pinned version
Running the install from the repo root let bunx float to the latest playwright, which fetched a browser build the test runtime (playwright 1.60.0, pinned in e2e) never looks for, so the browser scenarios failed to launch. Install from e2e so the resolved playwright matches the one the scenarios use.
1 parent 5665643 commit 39e7122

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,12 @@ jobs:
9494

9595
# `chromium` and the new `chromium-headless-shell` ship as separate
9696
# downloads; the browser-driven scenarios launch the headless shell.
97+
# Install from e2e so bunx resolves ITS pinned playwright (the version the
98+
# tests run against) rather than floating to the latest, which would fetch
99+
# a browser build the test runtime does not look for.
97100
- name: Install Playwright Chromium
98101
run: bunx playwright install --with-deps chromium chromium-headless-shell
102+
working-directory: e2e
99103

100104
# The `local` vitest project is excluded from the default `test` chain
101105
# (each scenario launches its own server), so run it as its own job.

0 commit comments

Comments
 (0)