Commit cb21525
committed
fix(react): keep native select options readable in dark mode
The native <select> option popup follows the control's opaque background
and color-scheme, not option-level styles. bg-transparent left the popup
white, so dark-mode options rendered near-white text on a white surface.
The dark:bg-input/30 fallback never applied: the dark: variant is gated on
a .dark ancestor class this app never sets (theming is prefers-color-scheme
driven).
Give the select a solid themed surface (bg-popover/text-popover-foreground),
add a hover:bg-accent state, and pin color-scheme via useIsDark so the native
popup follows the active theme. Fixes the Resume approvals dropdown in
setup-mcp and mcp-install-card, and every other NativeSelect.
Closes #12271 parent 1c1051c commit cb21525
2 files changed
Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
16 | 23 | | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
| 27 | + | |
20 | 28 | | |
21 | | - | |
| 29 | + | |
22 | 30 | | |
23 | 31 | | |
24 | 32 | | |
| |||
0 commit comments