Harden flaky e2e waits under CI shard load

Author: RhysSullivan

e2e/scenarios/auth-methods-ui.test.ts

@@ -38,8 +38,12 @@ scenario(
             waitUntil: "networkidle",
           });
           // The URL auto-probes (debounced); the method list appears once
-          // the probe lands.
-          await page.getByText("How does this server authenticate?").waitFor();
+          // the probe lands. Generous timeout: the probe request can queue
+          // behind a busy dev server under CI load, and there is no clean
+          // client-side re-trigger to poke mid-flight (the debounced probe
+          // only re-fires on a URL change, and "Try again" only appears
+          // after the probe has already failed).
+          await page.getByText("How does this server authenticate?").waitFor({ timeout: 90_000 });
         });
 
         await step("The probe seeded the detected method", async () => {

e2e/scenarios/health-checks-ui.test.ts

@@ -483,7 +483,7 @@ scenario(
               await page.getByPlaceholder("https://api.example.com/openapi.json").fill(spec);
               await page
                 .getByRole("heading", { name: "Health check (optional)" })
-                .waitFor({ timeout: 20_000 });
+                .waitFor({ timeout: 30_000 });
             });
 
             await step("Type to reach an operation past the preview's top slice", async () => {

e2e/selfhost/auth-methods-ui.test.ts

@@ -49,7 +49,10 @@ scenario(
           await page.goto(`/integrations/add/mcp?url=${encodeURIComponent(server.endpoint)}`, {
             waitUntil: "networkidle",
           });
-          await page.getByText("How does this server authenticate?").waitFor();
+          // Generous timeout: the debounced probe request can queue behind a
+          // busy dev server under CI load, and there is no clean client-side
+          // re-trigger to poke it mid-flight.
+          await page.getByText("How does this server authenticate?").waitFor({ timeout: 90_000 });
         });
 
         await step("The probe detected OAuth", async () => {

e2e/targets/cloud.ts

@@ -32,8 +32,12 @@ const cookiePair = (response: Response, name: string): string | undefined => {
 const signIn = async (email: string): Promise<string> => {
   const login = await fetch(new URL("/api/auth/login", CLOUD_BASE_URL), { redirect: "manual" });
   const stateCookie = cookiePair(login, "wos-login-state");
-  const authorizeUrl = new URL(login.headers.get("location") ?? "");
-  if (!stateCookie || !authorizeUrl.searchParams.get("state")) {
+  const location = login.headers.get("location");
+  if (!stateCookie || !location) {
+    throw new Error(`cloud signIn: login did not redirect to AuthKit (${login.status})`);
+  }
+  const authorizeUrl = new URL(location);
+  if (!authorizeUrl.searchParams.get("state")) {
     throw new Error(`cloud signIn: login did not redirect to AuthKit (${login.status})`);
   }
   // The emulator's hosted login signs in headlessly via login_hint (creating