Skip to content

Drop the empty bordered panel for no-auth connections#1181

Merged
RhysSullivan merged 1 commit into
mainfrom
fix-noauth-border-box
Jun 28, 2026
Merged

Drop the empty bordered panel for no-auth connections#1181
RhysSullivan merged 1 commit into
mainfrom
fix-noauth-border-box

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

The "Add connection" modal's auth-method panel always rendered a framed box (border, muted fill, padding) under the method selector. When No authentication is selected there are no credential fields to show, so the panel rendered as an empty bordered rectangle with nothing in it.

The frame now only applies when the panel actually has content; no-auth shows nothing between the selector and "Connection saved to".

Before After
before after

The change is scoped to the TabsContent className in add-account-modal.tsx: gate the rounded-md border ... p-4 styles on !isNoAuth.

The connect modal's auth-method panel always rendered a framed box
(border, muted fill, padding). With No authentication selected there are
no fields to show, so it appeared as an empty bordered rectangle below
the method selector. Only apply the frame when the panel has content.
@RhysSullivan RhysSullivan merged commit 5422ec3 into main Jun 28, 2026
11 of 14 checks passed
@greptile-apps

greptile-apps Bot commented Jun 28, 2026

Copy link
Copy Markdown

Greptile Summary

Hides the empty bordered panel in the "Add connection" modal when No authentication is selected, by conditionally applying the frame styles only when isNoAuth is false.

  • The single-line className string on TabsContent is replaced with a cn(...) call that omits rounded-md border border-border/60 bg-muted/15 p-4 when isNoAuth is true.
  • isNoAuth (method?.kind === "none") was already used to suppress the credential fields at line 1475, so this change follows an existing pattern in the same block.

Confidence Score: 5/5

Safe to merge — the change only removes decorative CSS classes from an already-empty container and does not touch any logic, state, or data flow.

The diff touches a single className prop. isNoAuth is a pre-existing boolean derived from method?.kind === 'none' and was already guarding the credential fields in the same JSX block, so the new guard is consistent and correctly scoped.

No files require special attention.

Important Files Changed

Filename Overview
packages/react/src/components/add-account-modal.tsx Gates the rounded-md border ... bg-muted/15 p-4 frame on !isNoAuth; consistent with the existing !isNoAuth guard on the credential fields at line 1475.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[TabsContent rendered] --> B{isNoAuth?}
    B -- Yes --> C[No frame styles applied\nmt-0 min-w-0 space-y-5 only]
    B -- No --> D[Full frame styles applied\nrounded-md border bg-muted p-4]
    C --> E{Credential fields}
    D --> E
    E -- isNoAuth --> F[Fields hidden — nothing rendered inside panel]
    E -- not isNoAuth --> G[OAuth / API-key / other credential fields shown]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[TabsContent rendered] --> B{isNoAuth?}
    B -- Yes --> C[No frame styles applied\nmt-0 min-w-0 space-y-5 only]
    B -- No --> D[Full frame styles applied\nrounded-md border bg-muted p-4]
    C --> E{Credential fields}
    D --> E
    E -- isNoAuth --> F[Fields hidden — nothing rendered inside panel]
    E -- not isNoAuth --> G[OAuth / API-key / other credential fields shown]
Loading

Reviews (1): Last reviewed commit: "Drop the empty bordered panel for no-aut..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant