Drop the empty bordered panel for no-auth connections#1181
Merged
Conversation
The connect modal's auth-method panel always rendered a framed box (border, muted fill, padding). With No authentication selected there are no fields to show, so it appeared as an empty bordered rectangle below the method selector. Only apply the frame when the panel has content.
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Add connection" modal's auth-method panel always rendered a framed box (border, muted fill, padding) under the method selector. When No authentication is selected there are no credential fields to show, so the panel rendered as an empty bordered rectangle with nothing in it.
The frame now only applies when the panel actually has content; no-auth shows nothing between the selector and "Connection saved to".
The change is scoped to the
TabsContentclassName inadd-account-modal.tsx: gate therounded-md border ... p-4styles on!isNoAuth.