Fix release publish workflow footguns#1294
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 3f9cf69 | Commit Preview URL Branch Preview URL |
Jul 04 2026, 02:17 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 3f9cf69 | Jul 04 2026, 02:20 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
changeset:versiononly when the changesets changelog step hits the transient GitHub GraphQL parse failures seen in Release logs.gh workflow run publish-executor-package.ymldispatch from Release. The pushedv*tag is now the single automatic Publish Executor trigger, whileworkflow_dispatchremains for repair runs.docker buildx imagetools create.Release diagnosis
I inspected recent failed Release runs:
28686830716,28489661728,28411073545,28358855701,28355916948,28354166786,28353275594,28352320755,28351802611,28351073786, and28350205006.The current noisy changesets failure is not a non-fast-forward branch push or a permissions error. The relevant recent failures die while
@changesets/changelog-githubis fetching GitHub changelog data:Several older failures were deterministic changeset authoring errors, for example:
Those should still fail. The wrapper exits immediately unless the log contains
Failed to parse data from GitHuborPremature close, and it resets generated files before retrying the transient case. The Release workflow already had a non-cancelling branch concurrency group, and the sampled logs did not show a changeset branch push race.The latest sampled failed Release run,
28686830716, passed changesets and failed later in package publish withnpm error code E404for@executor-js/codemode-core@1.5.28, so this PR does not claim to fix that separate npm permission or package availability issue.Publish trigger diagnosis
Publish Executor history showed paired automatic runs for the same tag, seconds apart:
v1.5.27:pushrun28490029741andworkflow_dispatchrun28490029285, both successful.v1.5.26:pushrun28411821883andworkflow_dispatchrun28411821591, both successful.v1.5.25:pushrun28393956665andworkflow_dispatchrun28393956319, both successful.The tag push path is reliable and directly tied to the validated release tag. Keeping it as the sole automatic path avoids duplicate publishes for the same release.
Self-host Docker notes
The ARM runner label is from Blacksmith instance type docs:
blacksmith-4vcpu-ubuntu-2404-armat https://docs.blacksmith.sh/blacksmith-runners/overview.md.The workflow still publishes the primary GHCR tags and, when
GHCR_LEGACY_TOKENis configured, mirrors the same tag set intoghcr.io/rhyssullivan/executor-selfhostduring the org transition.Because
publish-selfhost-docker.ymlisworkflow_dispatchonly, it still needs a post-merge manual dispatch against a real release tag to validate the full registry push and manifest merge path.Verification
bash /tmp/release-wrapper-review-test.sh: covers attempt-1 success, deterministic non-transient failure without retry, transientPremature closefailure across all configured attempts with a nonzero exit, and transient-once success. The transient-once case also creates an untracked packageCHANGELOG.mdand requires the retry cleanup to remove it before the successful attempt.go run github.com/rhysd/actionlint/cmd/actionlint@latest -config-file /tmp/actionlint-release-runner-label.yaml .github/workflows/release.ymldocker buildx imagetools createargument construction.