Skip to content

Desktop: Reset data recovery + crash issue template#965

Merged
RhysSullivan merged 3 commits into
mainfrom
claude/desktop-reset-state
Jun 12, 2026
Merged

Desktop: Reset data recovery + crash issue template#965
RhysSullivan merged 3 commits into
mainfrom
claude/desktop-reset-state

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Follow-up to #961. Gives users on hard-crashed states a way out, and makes new crash reports easier to triage.

  • Reset data: when the local server can't start (failed migration, corrupt SQLite), the data dir is moved aside into ~/.executor/backups/<stamp>/ — never deleted — and the app starts fresh. Offered on the in-window crash screen (link) and the fatal-startup dialog (button), each behind a native confirm.
  • Crash issue template (.github/ISSUE_TEMPLATE/desktop-crash.yml): asks for version, OS, when it crashes, and the diagnostics zip / log file.

The damaged-db → reset → healed flow, recorded by the e2e scenario (corrupted bytes verified preserved in the backup):

Desktop · reset data recovers from a damaged database, backing it up first (desktop)

A failed migration or corrupt SQLite makes the sidecar fail to start
forever — updating can't fix it. Reset moves the data dir aside (never
deletes) into ~/.executor/backups/<stamp>/ and starts fresh, so the
user's connections and secrets stay recoverable.

- resetExecutorState() backs up data.db (+ wal/shm) and server-control
- Offered two ways: a 'Reset data' link on the in-window crash screen
  (for crashes under a live window) and a 'Reset data and retry…'
  button on the fatal-startup dialog (for boot failures), each behind a
  native confirm
- New e2e scenario: corrupts data.db, confirms restart alone fails, then
  resets and asserts the app heals AND the corrupted db is preserved in
  the backup dir
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing a13587f Commit Preview URL

Branch Preview URL
Jun 12 2026, 04:55 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud a13587f Jun 12 2026, 04:55 AM

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@965

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@965

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@965

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@965

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@965

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@965

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@965

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@965

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@965

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@965

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@965

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@965

executor

npm i https://pkg.pr.new/executor@965

commit: a13587f

The crash-screen reset copy now says what reset is FOR (clears a
damaged database) rather than dwelling on the backup. After a reset
completes, an info dialog names the exact backup folder and offers
Show in folder — so 'your data is backed up' is something the user can
act on, not just a promise.
@RhysSullivan RhysSullivan marked this pull request as ready for review June 12, 2026 04:58
@RhysSullivan RhysSullivan merged commit 815a0df into main Jun 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant