Remove the D1-to-R2 oversized-value offload#967
Merged
Conversation
The transparent D1 driver wrap (intercept bound params >800KB, stash in R2 under a content hash, rehydrate pointer strings on read) existed only because resolved OpenAPI specs were inlined in integration.config and D1 caps a value at ~1-2MB. Specs now live in the blob seam, written straight to R2 through the handle's blobs backend, so nothing that flows through D1 approaches the cap: across the whole fleet the largest non-spec values are tool rows ~165KB, definitions ~256KB, and plugin_storage ~206KB. The canonical deployment's database was scanned for offload pointer strings before removal — zero exist in any table, so this is code-only. A deployment that still had legacy oversized rows stored as pointers would need the spec backfill before taking this change. The workerd e2e still pushes a ~1MB spec through the real worker; it now proves the spec lands in the R2 blob seam rather than the offload. maxBoundParameters stays — that is D1's parameter-count platform limit, unrelated to value size.
RhysSullivan
force-pushed
the
remove-d1-blob-offload
branch
from
3ace36b to
bfcedc6
Compare
This was referenced Jun 12, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | bfcedc6 | Commit Preview URL Branch Preview URL |
Jun 12 2026, 05:25 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | bfcedc6 | Jun 12 2026, 05:26 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes the transparent D1 driver wrap that intercepted bound parameters >800KB, stashed them in R2 under a content hash, and rehydrated pointer strings on read.
createD1ExecutorDbhands drizzle the rawD1Database; the handle's blob-seam backend (makeR2BlobStore) is unchanged.Why it existed, why it can go
It existed only because resolved OpenAPI specs were inlined in
integration.configand D1 caps a value at ~1-2MB. Specs now live in the blob seam, written straight to R2, so nothing that flows through D1 approaches the cap: across the whole production fleet the largest non-spec values are tool rows ~165KB, definitions ~256KB, and plugin_storage ~206KB.Safety
The canonical deployment's database was scanned for offload pointer strings before removal — zero exist in any table, so this is code-only. A deployment that still had legacy oversized rows stored as pointers would need the spec backfill before taking this change.
maxBoundParameters: 100stays — that's D1's parameter-count platform limit, unrelated to value size.Testing
The workerd e2e still pushes a ~1MB spec through the real worker; it now proves the spec lands in the R2 blob seam rather than the offload. Full gates green.
Stack