Close trace-id test lane and split improvement 9

Author: marcnulu

docs/main.command.trace-id.test.complete.md

@@ -0,0 +1,43 @@
+# Command: trace-id Test Lane — Complete
+
+Status: `complete` (Phases 1-4 done, Phase 5 absorbed into improvement 9)
+Date completed: 2026-03-24
+Original date: 2026-03-03
+
+## What Was Done
+
+Phased test suite for trace-id, implemented in `julia-tests/runtests.trace-id.jl`.
+
+### Phase 1: CLI Contract — DONE
+- `trace-id --help` exposes command and required flags
+- Missing required args fail with actionable errors
+- Invalid `--format` / guardrail args fail with actionable errors
+
+### Phase 2: Core Heuristic Roles — DONE
+- Detect `define` sites for identifier constants
+- Detect `produce` publish/send/emit sites
+- Detect `consume` subscribe/bind/routing sites
+- Detect `trigger` pattern registration sites
+
+### Phase 3: Output Contracts — DONE
+- JSON output schema is stable for downstream tooling
+- Terminal output includes grouped role sections
+- Empty-result behavior is deterministic
+
+### Phase 4: Scope/stdin/Depth Guardrails — DONE
+- Scope and extension filtering constraints hold
+- stdin-limited file set behavior works
+- Depth guardrail and `--force` semantics are consistent
+
+### Phase 5: Cross-Command JSON Pipeline — ABSORBED
+Moved to `docs/main.improvement.9.trace-id.todo.current.md`.
+The `@test_broken` placeholders in `runtests.trace-id.jl` flip when merge edge-type lands.
+
+## Test Counts (at close)
+
+42 pass, 4 broken (Phase 5 pipeline placeholders)
+
+## Artifacts
+
+- `julia-tests/runtests.trace-id.jl`
+- `julia-tests/main.command.trace-id.test.jl`

docs/main.command.trace-id.test.todo.current.md

@@ -1,7 +1,11 @@
 # Demo: Sudoku + trace-id (Pure Separation Architecture)
 
-Status: `todo.current` (active — Phase 4 complete, Phase 5 next)
-Date: 2026-03-13
+Status: `todo.current` (active — standalone lane, Phase 5 HTML5 in progress)
+Date: 2026-03-24 (standalone since 2026-03-24, originally 2026-03-13)
+
+Note: This lane was formerly Lane 2 of improvement 9. Now standalone because
+the Sudoku demo *uses* trace-id but doesn't *change* it. The merge edge-type
+pipeline work remains in `docs/main.improvement.9.trace-id.todo.current.md`.
 
 ## Phase 1 Complete (2026-03-13)
 

docs/main.command.trace-id.test.todo.current.reference.md

@@ -1,34 +1,16 @@
-# Improvement 9: trace-id Pipeline + Sudoku Demo
+# Improvement 9: merge edge-type Pipeline
 
-Status: `todo.current` (active — Sudoku Phase 1-3 complete, Phase 4 next)
-Date: 2026-03-13
+Status: `todo.current` (active — focused on merge edge-type only)
+Date: 2026-03-24
 
 ## Focus
 
-Two lanes, both trace-id ecosystem:
+Single lane: teach `merge --stdin` to retain `edge_type` from trace-id JSON.
 
-1. **merge edge-type pipeline** — `trace-id --json | merge --stdin` retains `edge_type`
-2. **Sudoku demo** — full showcase of recur as discoverability engine
+The Sudoku demo (formerly Lane 2) is now its own standalone lane:
+`docs/main.demo.sudoku.trace-id.todo.current.md`
 
-## Progress (2026-03-13)
-
-**Sudoku demo Phase 1+2+3 complete:** 644 tests green (32 + 20 + 46 + rest of suite).
-- Phase 1: file protocol proof — plain .txt, default vocab, config isolation, edge_type
-- Phase 2: Recur.jl wrapper + puzzle fixture — full Julia→subprocess→JSON loop
-- Phase 3: Generator.jl — Sudoku geometry, flow file authoring, cascades.json generation
-  - Fixed: box.5 → box.2 (handwritten fixture had wrong box number, Generator computes correctly)
-  - Proven: 20 unique peers per cell, all subscribe lines reference identifier
-- Artifacts: `demos/sudoku/julia/` (Recur.jl, Generator.jl), `julia-tests/runtests.demo.sudoku.phase3.jl`
-
-**Phase 4 next:**
-- Phase 1d config isolation (fragile repo config dependency)
-- Dogfooding doc validation (speculative vocabulary)
-
-**Lane 1 (merge edge-type) unchanged** — Phase 5 `@test_broken` still waiting.
-
-## Lane 1: merge edge-type
-
-### What's needed
+## What's Needed
 
 `merge --stdin` currently extracts file paths from JSON and builds a file-path tree.
 It doesn't understand the trace-id JSON shape (`define`/`produce`/`consume`/`trigger` arrays)
@@ -40,7 +22,7 @@ To make `trace-id --json | merge --stdin --json` output include `edge_type`:
 2. Track `edge_type` per path through merge
 3. Include `edge_type` in merge JSON output
 
-### Test
+## Test Gate
 
 `julia-tests/runtests.trace-id.jl` — Phase 5: "trace-id -> merge (full composition placeholder)"
 
@@ -50,34 +32,25 @@ To make `trace-id --json | merge --stdin --json` output include `edge_type`:
 
 Flip to `@test` when implemented.
 
+Also absorbs the trace-id test lane Phase 5 (cross-command JSON pipeline contracts).
+That lane's Phases 1-4 are complete and wired into the suite — see
+`docs/main.command.trace-id.test.complete.md` for the record.
+
 ### Descoped
 
 `trace -> merge`, `callers -> merge`, `callees -> merge` edge_type tests —
 those commands don't produce `edge_type`. Marked `@test_skip` permanently.
 
-## Lane 2: Sudoku Demo
-
-Full planning in `docs/main.demo.sudoku.trace-id.todo.current.md`.
-
-7 phases:
-1. File protocol spec + keyword vocabulary
-2. Julia CLI prototype — hardcoded puzzle, call recur, verify cascade JSON
-3. Julia puzzle package generator — produce all JSON artifacts for one puzzle
-4. Julia CLI game loop — playable terminal game
-5. HTML5 static game — load puzzle package, full browser game, no recur at runtime
-6. Optional: Julia local server mode for live recur queries from HTML5
-7. Demo script (`demos/sudoku/demo.ps1`)
-
 ## Close-out Criteria
 
 1. Phase 5 trace-id → merge test flips from `@test_broken` → `@test`
-2. Sudoku demo Phase 1-5 complete (Phase 6-7 optional)
-3. Create `docs/main.improvement.9.trace-id.complete.md`
-4. Delete this `.current.md`
+2. Create `docs/main.improvement.9.trace-id.complete.md`
+3. Delete this `.current.md`
 
 ## References
 
-- `julia-tests/runtests.trace-id.jl` — Phase 5 (Lane 1)
+- `julia-tests/runtests.trace-id.jl` — Phase 5 tests
 - `src/main_command_merge_impl.rs` — merge stdin implementation
-- `docs/main.demo.sudoku.trace-id.todo.current.md` — Sudoku demo (Lane 2)
+- `docs/main.command.trace-id.test.complete.md` — test lane record (Phases 1-4 done)
+- `docs/main.demo.sudoku.trace-id.todo.current.md` — Sudoku demo (standalone)
 - `docs/main.improvement.9.trace-id.todo.future-plan.md` — original future-plan

docs/main.command.trace-id.test.todo.trigger.event.md

@@ -28,10 +28,10 @@ mod main_command_merge_impl;
 mod main_command_related_impl;
 mod main_command_stats_impl;
 mod main_command_stats_stdin;
-mod main_command_trait_impl;
 mod main_command_trace_id_impl;
 mod main_command_trace_impl;
 mod main_command_trace_stats_impl;
+mod main_command_trait_impl;
 mod main_command_tree_impl;
 
 #[derive(Parser)]

docs/main.demo.sudoku.trace-id.todo.current.md

@@ -48,4 +48,3 @@ pub fn execute(
 
     Ok(())
 }
-

docs/main.improvement.9.trace-id.todo.current.md

@@ -68,4 +68,3 @@ pub fn execute(
 
     Ok(())
 }
-

src/main.rs

@@ -64,10 +64,10 @@ fn ensure_config_exists(root: &Path) -> anyhow::Result<PathBuf> {
 }
 
 fn load_config_table(path: &Path) -> anyhow::Result<toml::value::Table> {
-    let text = fs::read_to_string(path)
-        .with_context(|| format!("Failed to read {}", path.display()))?;
-    let value: TomlValue = toml::from_str(&text)
-        .with_context(|| format!("Failed to parse {}", path.display()))?;
+    let text =
+        fs::read_to_string(path).with_context(|| format!("Failed to read {}", path.display()))?;
+    let value: TomlValue =
+        toml::from_str(&text).with_context(|| format!("Failed to parse {}", path.display()))?;
 
     match value {
         TomlValue::Table(table) => Ok(table),
@@ -134,8 +134,13 @@ fn get_trait_value(root: &Path, key: &str, json_output: bool) -> anyhow::Result<
     let path = ensure_config_exists(root)?;
     let table = load_config_table(&path)?;
     let key_path = normalize_trait_key_path(key, false)?;
-    let value = get_value_at_path(&table, &key_path)
-        .with_context(|| format!("Key '{}' not found in {}", key_path.join("."), path.display()))?;
+    let value = get_value_at_path(&table, &key_path).with_context(|| {
+        format!(
+            "Key '{}' not found in {}",
+            key_path.join("."),
+            path.display()
+        )
+    })?;
 
     if json_output {
         let payload = json!({
@@ -242,10 +247,7 @@ fn set_value_at_path(
             .expect("entry should be table after table check");
     }
 
-    current.insert(
-        path.last().expect("path must not be empty").clone(),
-        value,
-    );
+    current.insert(path.last().expect("path must not be empty").clone(), value);
     Ok(())
 }
 
@@ -314,7 +316,10 @@ mod tests {
     fn parse_cli_value_infers_common_scalar_types() {
         assert_eq!(parse_cli_value("true"), TomlValue::Boolean(true));
         assert_eq!(parse_cli_value("42"), TomlValue::Integer(42));
-        assert_eq!(parse_cli_value("\"hello\""), TomlValue::String("hello".to_string()));
+        assert_eq!(
+            parse_cli_value("\"hello\""),
+            TomlValue::String("hello".to_string())
+        );
         assert_eq!(parse_cli_value("raw"), TomlValue::String("raw".to_string()));
     }