feat: publish visit updated for approved visit registration updates and align seed data (#1524)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: yoganandaness

apps/backend/db_patches/0210_AddIdPkToVisitsHasUsers.sql

@@ -0,0 +1,33 @@
+DO
+$$
+BEGIN
+  IF register_patch('0210_AddIdPkToVisitsHasUsers.sql', 'GitHubCopilot', 'Add UUID primary key to visits_has_users', '2026-05-19') THEN
+    BEGIN
+      CREATE EXTENSION IF NOT EXISTS "uuid-ossp";
+
+      ALTER TABLE visits_has_users
+      ADD COLUMN id UUID;
+
+      UPDATE visits_has_users
+      SET id = uuid_generate_v4()
+      WHERE id IS NULL;
+
+      ALTER TABLE visits_has_users
+      ALTER COLUMN id SET NOT NULL;
+
+      ALTER TABLE visits_has_users
+      ALTER COLUMN id SET DEFAULT uuid_generate_v4();
+
+      ALTER TABLE visits_has_users
+      DROP CONSTRAINT IF EXISTS visits_has_users_pkey;
+
+      ALTER TABLE visits_has_users
+      ADD CONSTRAINT visits_has_users_pkey PRIMARY KEY (id);
+
+      ALTER TABLE visits_has_users
+      ADD CONSTRAINT visits_has_users_visit_id_user_id_key UNIQUE (visit_id, user_id);
+    END;
+  END IF;
+END;
+$$
+LANGUAGE plpgsql;

apps/backend/db_patches/db_seeds/0001_ProposalForScheduling.sql

@@ -80,6 +80,7 @@ BEGIN
      , comment_for_management
      , comment_for_user
      , notified
+    , management_decision_submitted
      , submitted
     )
     VALUES 
@@ -97,6 +98,7 @@ BEGIN
      , NULL              
      , NULL              
      , true              
+    , true              
      , true              
     );
 
@@ -120,6 +122,7 @@ BEGIN
      , comment_for_management
      , comment_for_user
      , notified
+    , management_decision_submitted
      , submitted
     )
     VALUES 
@@ -137,6 +140,7 @@ BEGIN
      , NULL              
      , NULL              
      , true              
+    , true              
      , true              
     );
 

apps/backend/db_patches/db_seeds/0008_VisitTemplate.sql

@@ -0,0 +1,48 @@
+DO
+$DO$
+DECLARE
+  visit_registration_template_id_var int;
+  visit_registration_template_topic_id_var int;
+BEGIN
+  INSERT INTO templates(name, description, is_archived, group_id)
+  VALUES (
+    'default visit registration template',
+    'default visit registration template',
+    false,
+    'VISIT_REGISTRATION'
+  )
+  RETURNING template_id INTO visit_registration_template_id_var;
+
+  INSERT INTO topics(topic_title, is_enabled, sort_order, template_id)
+  VALUES (
+    'Visit registration',
+    true,
+    0,
+    visit_registration_template_id_var
+  )
+  RETURNING topic_id INTO visit_registration_template_topic_id_var;
+
+  INSERT INTO templates_has_questions(
+    question_id,
+    template_id,
+    topic_id,
+    sort_order,
+    config,
+    dependencies_operator
+  )
+  VALUES (
+    'visit_basis',
+    visit_registration_template_id_var,
+    visit_registration_template_topic_id_var,
+    0,
+    '{"titlePlaceholder":"Title","required":false,"small_label":"","tooltip":"","readPermissions":[]}',
+    'AND'
+  );
+
+  INSERT INTO active_templates(group_id, template_id)
+  VALUES ('VISIT_REGISTRATION', visit_registration_template_id_var)
+  ON CONFLICT (group_id)
+  DO UPDATE SET template_id = EXCLUDED.template_id;
+END;
+$DO$
+LANGUAGE plpgsql;

apps/backend/src/datasources/mockups/VisitDataSource.ts

@@ -14,7 +14,18 @@ import { dummyUserWithRole } from './UserDataSource';
 export class VisitDataSourceMock implements VisitDataSource {
   private visits: Visit[];
   private visitsHasVisitors: VisitRegistration[];
+  private nextRegistrationId = 1;
+
+  private createRegistrationId() {
+    const id = `mock-visit-registration-${this.nextRegistrationId}`;
+    this.nextRegistrationId += 1;
+
+    return id;
+  }
+
   init() {
+    this.nextRegistrationId = 1;
+
     this.visits = [
       new Visit(1, 1, 1, dummyUserWithRole.id, new Date(), 1),
       new Visit(3, 3, 3, dummyUserWithRole.id, new Date(), 3),
@@ -23,6 +34,7 @@ export class VisitDataSourceMock implements VisitDataSource {
 
     this.visitsHasVisitors = [
       new VisitRegistration(
+        this.createRegistrationId(),
         1,
         1,
         1,
@@ -31,6 +43,7 @@ export class VisitDataSourceMock implements VisitDataSource {
         VisitRegistrationStatus.DRAFTED
       ),
       new VisitRegistration(
+        this.createRegistrationId(),
         1,
         2,
         2,
@@ -120,9 +133,10 @@ export class VisitDataSourceMock implements VisitDataSource {
       args.team?.forEach((userId) => {
         this.visitsHasVisitors.push(
           new VisitRegistration(
-            this.visitsHasVisitors.length,
-            userId,
+            this.createRegistrationId(),
             args.visitId,
+            userId,
+            null,
             new Date(),
             new Date(),
             VisitRegistrationStatus.DRAFTED

apps/backend/src/datasources/postgres/records.ts

@@ -241,6 +241,7 @@ export interface UserRecord {
 }
 
 export interface VisitRegistrationRecord {
+  id: string;
   user_id: number;
   visit_id: number;
   registration_questionary_id: number | null;
@@ -976,6 +977,7 @@ export const createVisitRegistrationObject = (
   record: VisitRegistrationRecord
 ) => {
   return new VisitRegistration(
+    record.id,
     record.visit_id,
     record.user_id,
     record.registration_questionary_id,

apps/backend/src/eventHandlers/messageBroker.ts

@@ -44,6 +44,7 @@ export const EXCHANGE_NAME =
 enum RABBITMQ_VISIT_EVENT_TYPE {
   VISIT_CREATED = 'VISIT_CREATED',
   VISIT_DELETED = 'VISIT_DELETED',
+  VISIT_UPDATED = 'VISIT_UPDATED',
 }
 
 type Member = {
@@ -486,26 +487,40 @@ export async function createPostToRabbitMQHandler() {
         );
         break;
       }
+      case Event.VISIT_REGISTRATION_UPDATED:
       case Event.VISIT_REGISTRATION_APPROVED:
       case Event.VISIT_REGISTRATION_CANCELLED: {
         const { visitregistration: visitRegistration } = event;
+
+        if (
+          event.type === Event.VISIT_REGISTRATION_UPDATED &&
+          visitRegistration.status !== VisitRegistrationStatus.APPROVED
+        ) {
+          break;
+        }
+
         const proposal = await proposalDataSource.getProposalByVisitId(
           visitRegistration.visitId
         );
         const proposalPayload = await getProposalMessageData(proposal);
         const user = await userDataSource.getUser(visitRegistration.userId);
         const jsonMessage = JSON.stringify({
+          id: visitRegistration.id,
           startAt: visitRegistration.startsAt,
           endAt: visitRegistration.endsAt,
           visitorId: user!.oidcSub,
           proposal: JSON.parse(proposalPayload),
         });
+        let rabbitMQVisitEventType = RABBITMQ_VISIT_EVENT_TYPE.VISIT_UPDATED;
+        if (event.type === Event.VISIT_REGISTRATION_APPROVED) {
+          rabbitMQVisitEventType = RABBITMQ_VISIT_EVENT_TYPE.VISIT_CREATED;
+        } else if (event.type === Event.VISIT_REGISTRATION_CANCELLED) {
+          rabbitMQVisitEventType = RABBITMQ_VISIT_EVENT_TYPE.VISIT_DELETED;
+        }
 
         await rabbitMQ.sendMessageToExchange(
           EXCHANGE_NAME,
-          event.type === Event.VISIT_REGISTRATION_APPROVED
-            ? RABBITMQ_VISIT_EVENT_TYPE.VISIT_CREATED
-            : RABBITMQ_VISIT_EVENT_TYPE.VISIT_DELETED,
+          rabbitMQVisitEventType,
           jsonMessage
         );
 

apps/backend/src/events/applicationEvents.ts

@@ -396,6 +396,12 @@ interface VisitCreatedEvent extends GeneralEvent {
   type: Event.VISIT_CREATED;
   visit: Visit;
 }
+
+interface VisitRegistrationUpdatedEvent extends GeneralEvent {
+  type: Event.VISIT_REGISTRATION_UPDATED;
+  visitregistration: VisitRegistration;
+}
+
 interface VisitRegistrationApprovedEvent extends GeneralEvent {
   type: Event.VISIT_REGISTRATION_APPROVED;
   visitregistration: VisitRegistration;
@@ -545,6 +551,7 @@ export type ApplicationEvent =
   | InternalReviewUpdated
   | InternalReviewDeleted
   | VisitCreatedEvent
+  | VisitRegistrationUpdatedEvent
   | VisitRegistrationApprovedEvent
   | VisitRegistrationCancelledEvent
   | UserDataAccessUpdatedEvent

apps/backend/src/events/event.enum.ts

@@ -117,6 +117,7 @@ export enum Event {
   INSTRUMENTS_REMOVED_FROM_TECHNIQUE = 'INSTRUMENTS_REMOVED_FROM_TECHNIQUE',
   PROPOSAL_ASSIGNED_TO_TECHNIQUES = 'PROPOSAL_ASSIGNED_TO_TECHNIQUES',
   VISIT_REGISTRATION_APPROVED = 'VISIT_REGISTRATION_APPROVED',
+  VISIT_REGISTRATION_UPDATED = 'VISIT_REGISTRATION_UPDATED',
   VISIT_REGISTRATION_CANCELLED = 'VISIT_REGISTRATION_CANCELLED',
   EXPERIMENT_ESF_SUBMITTED = 'EXPERIMENT_ESF_SUBMITTED',
   EXPERIMENT_ESF_APPROVED_BY_IS = 'EXPERIMENT_ESF_APPROVED_BY_IS',

apps/backend/src/models/VisitRegistration.ts

@@ -1,5 +1,6 @@
 export class VisitRegistration {
   constructor(
+    public id: string,
     public visitId: number,
     public userId: number,
     public registrationQuestionaryId: number | null,

apps/backend/src/mutations/VisitMutations.ts

@@ -252,6 +252,7 @@ export default class VisitMutations {
   }
 
   @Authorized()
+  @EventBus(Event.VISIT_REGISTRATION_UPDATED)
   async updateVisitRegistration(
     agent: UserWithRole | null,
     args: UpdateVisitRegistrationArgs