clean up tests from legacy fields

Author: bolmsten

apps/backend/src/mutations/UserMutations.spec.ts

@@ -270,7 +270,6 @@ describe('updateUserByOidcSub', () => {
     expect(result).toEqual({
       ...dummyUser,
       firstname: 'OfficerUpdatedJane',
-      department: 'Updated Department',
     });
   });
   test('A user cannot update another user by OIDC sub', async () => {
@@ -308,8 +307,6 @@ describe('updateUserByOidcSub', () => {
 
     expect(result).toEqual({
       ...dummyUser,
-      telephone: '+1-555-9999',
-      position: 'Senior Architect',
     });
   });
 

apps/e2e/cypress/e2e/personalInformation.cy.ts

@@ -12,12 +12,9 @@ context('Personal information tests', () => {
 
   const newFirstName = faker.name.firstName();
   const newLastName = faker.name.lastName();
-  const newDepartment = faker.commerce.department();
   const otherOrg = faker.commerce.department();
   const otherInstitution = 'Other';
   const newPreferredName = faker.hacker.noun();
-  const newPosition = faker.random.word().split(' ')[0];
-  const newTelephone = faker.phone.number('0##########');
 
   it('Should be able to see user officer role in use', () => {
     if (featureFlags.getEnabledFeatures().get(FeatureId.USER_MANAGEMENT)) {
@@ -65,12 +62,6 @@ context('Personal information tests', () => {
 
       cy.get("[name='preferredname']").clear().type(newPreferredName);
 
-      cy.get("[name='position']").clear().type(newPosition);
-
-      cy.get("[name='department']").clear().type(newDepartment);
-
-      cy.get("[name='telephone']").clear().type(newTelephone);
-
       cy.get("[name='institutionId']").clear().type(otherInstitution);
 
       cy.get('[data-cy="institution-options"] li')
@@ -92,12 +83,6 @@ context('Personal information tests', () => {
       cy.get("[name='preferredname']")
         .invoke('val')
         .should('eq', newPreferredName);
-
-      cy.get("[name='position']").invoke('val').should('eq', newPosition);
-
-      cy.get("[name='department']").invoke('val').should('eq', newDepartment);
-
-      cy.get("[name='telephone']").invoke('val').should('eq', newTelephone);
     });
 
     it('User Officer should be able to see all and change roles if there are multiple', () => {

apps/e2e/cypress/e2e/userAdministration.cy.ts

@@ -7,10 +7,7 @@ import initialDBData from '../support/initialDBData';
 context('User administration tests', () => {
   const newFirstName = faker.name.firstName();
   const newLastName = faker.name.lastName();
-  const newDepartment = faker.commerce.department();
   const newPrefferedName = faker.hacker.noun();
-  const newPosition = faker.random.word().split(' ')[0];
-  const newTelephone = faker.phone.number('0##########');
   const newInstitution = faker.company.name();
   const placeholderUser = initialDBData.users.placeholderUser;
   const title = faker.lorem.words(2);
@@ -38,12 +35,6 @@ context('User administration tests', () => {
 
     cy.get("[name='preferredname']").clear().type(newPrefferedName);
 
-    cy.get("[name='position']").clear().type(newPosition);
-
-    cy.get("[name='department']").clear().type(newDepartment);
-
-    cy.get("[name='telephone']").clear().type(newTelephone);
-
     cy.get("[name='otherInstitution']").clear().type(newInstitution);
 
     cy.contains('Update Profile').click();
@@ -59,12 +50,6 @@ context('User administration tests', () => {
     cy.get("[name='preferredname']")
       .invoke('val')
       .should('eq', newPrefferedName);
-
-    cy.get("[name='position']").invoke('val').should('eq', newPosition);
-
-    cy.get("[name='department']").invoke('val').should('eq', newDepartment);
-
-    cy.get("[name='telephone']").invoke('val').should('eq', newTelephone);
   });
 
   it('Should be able to invite user or fap reviewer by email', function () {