Skip to content

Commit d861746

Browse files
test: fix flaky e2e test by updating request alias for user fetching (#1275)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent 49d374a commit d861746

1 file changed

Lines changed: 6 additions & 12 deletions

File tree

apps/e2e/cypress/e2e/peopleTable.cy.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -433,21 +433,18 @@ context('PageTable component tests', () => {
433433
});
434434

435435
cy.intercept('POST', '/graphql', (req) => {
436-
return new Promise((resolve) => {
437-
setTimeout(() => resolve(req.continue()), 1000); // delay by 1 second to see the loader
438-
});
439-
}).as('delayedRequest');
436+
if (req.body?.operationName === 'getUsers') {
437+
req.alias = 'getUsers';
438+
}
439+
});
440440

441441
cy.get('[data-cy="people-table"] thead')
442442
.contains('Firstname')
443443
.parent()
444444
.find('[data-testid="mtableheader-sortlabel"]')
445445
.click();
446446

447-
cy.get('[data-cy="people-table"] [role="progressbar"]').should('exist');
448-
449-
cy.wait('@delayedRequest');
450-
447+
cy.wait('@getUsers');
451448
cy.finishedLoading();
452449

453450
cy.get('[data-cy="people-table"] tbody tr')
@@ -465,10 +462,7 @@ context('PageTable component tests', () => {
465462
.find('[data-testid="mtableheader-sortlabel"]')
466463
.click();
467464

468-
cy.get('[data-cy="people-table"] [role="progressbar"]').should('exist');
469-
470-
cy.wait('@delayedRequest');
471-
465+
cy.wait('@getUsers');
472466
cy.finishedLoading();
473467

474468
cy.get('[data-cy="people-table"] tbody tr')

0 commit comments

Comments
 (0)