feat: allow pdf to be downloaded for draft proposals (#1454)

Author: ellen-wright

apps/backend/src/factory/pdf/proposal.ts

@@ -21,7 +21,6 @@ import { getTopicActiveAnswers } from '../../models/ProposalModelFunctions';
 import { Answer, QuestionaryStep } from '../../models/Questionary';
 import { isRejection } from '../../models/Rejection';
 import { Review } from '../../models/Review';
-import { Roles } from '../../models/Role';
 import { Sample } from '../../models/Sample';
 import {
   TechnicalReview,
@@ -260,9 +259,6 @@ export const collectProposalPDFData = async (
   if (proposal === null) {
     throw new Error('Proposal not found');
   }
-  if (!proposal.submitted && user.currentRole?.shortCode == Roles.USER) {
-    throw new Error('PDF cannot be downloaded pre submission ');
-  }
 
   const call = await baseContext.queries.call.get(user, proposal.callId);
 

apps/frontend/src/components/proposal/ProposalSummary.tsx

@@ -35,7 +35,6 @@ function ProposalReview({ confirm }: ProposalSummaryProps) {
 
   const { api } = useDataApiWithFeedback();
   const isUserOfficer = useCheckAccess([UserRole.USER_OFFICER]);
-  const isUser = useCheckAccess([UserRole.USER]);
   const { isInternalUser } = useContext(UserContext);
   const callHasEnded = isCallEnded(
     state.proposal.call?.startCall,
@@ -193,9 +192,7 @@ function ProposalReview({ confirm }: ProposalSummaryProps) {
           onClick={() =>
             downloadPDFProposal([proposal.primaryKey], proposal.title)
           }
-          disabled={
-            !allStepsComplete || isSubmitting || (!proposal.submitted && isUser)
-          }
+          disabled={!allStepsComplete || isSubmitting}
           color="secondary"
         >
           Download PDF

apps/frontend/src/components/proposal/ProposalTable.tsx

@@ -288,22 +288,14 @@ const ProposalTable = ({
               },
             };
           },
-          (rowData) => {
-            const isSubmitted = rowData.submitted;
-
-            return {
-              icon: GetAppIcon,
-              tooltip: !isSubmitted
-                ? 'Only submitted proposals can be downloaded'
-                : 'Download Proposal',
-              disabled: !isSubmitted,
-
-              onClick: (event, rowData) =>
-                downloadPDFProposal(
-                  [(rowData as PartialProposalsDataType).primaryKey],
-                  (rowData as PartialProposalsDataType).title
-                ),
-            };
+          {
+            icon: GetAppIcon,
+            tooltip: 'Download proposal',
+            onClick: (event, rowData) =>
+              downloadPDFProposal(
+                [(rowData as PartialProposalsDataType).primaryKey],
+                (rowData as PartialProposalsDataType).title
+              ),
           },
           (rowData) => {
             const isPI = rowData.proposerId === userContext.user.id;