Skip to content

Commit e8d29e8

Browse files
committed
fix(backend): align mock invite isExpired filter with postgres
The mock used `if (filter.isExpired)`, so passing false skipped the check, and its inner logic was inverted relative to the real datasource: true excluded expired invites instead of selecting them. Match the postgres semantics so tests can exercise expiry filtering.
1 parent 68bd9b4 commit e8d29e8

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

apps/backend/src/datasources/mockups/InviteDataSource.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,11 @@ export class InviteDataSourceMock implements InviteDataSource {
154154
}
155155
}
156156

157-
if (filter.isExpired) {
158-
if (invite.expiresAt && invite.expiresAt < new Date()) {
157+
if (filter.isExpired !== undefined) {
158+
const isExpired =
159+
invite.expiresAt !== null && invite.expiresAt < new Date();
160+
161+
if (isExpired !== filter.isExpired) {
159162
return false;
160163
}
161164
}
@@ -240,8 +243,11 @@ export class InviteDataSourceMock implements InviteDataSource {
240243
}
241244
}
242245

243-
if (filter.isExpired) {
244-
if (invite.expiresAt && invite.expiresAt < new Date()) {
246+
if (filter.isExpired !== undefined) {
247+
const isExpired =
248+
invite.expiresAt !== null && invite.expiresAt < new Date();
249+
250+
if (isExpired !== filter.isExpired) {
245251
return false;
246252
}
247253
}
@@ -293,8 +299,11 @@ export class InviteDataSourceMock implements InviteDataSource {
293299
}
294300
}
295301

296-
if (filter.isExpired) {
297-
if (invite.expiresAt && invite.expiresAt < new Date()) {
302+
if (filter.isExpired !== undefined) {
303+
const isExpired =
304+
invite.expiresAt !== null && invite.expiresAt < new Date();
305+
306+
if (isExpired !== filter.isExpired) {
298307
return false;
299308
}
300309
}

0 commit comments

Comments
 (0)