Skip to content

BREAKING CHANGE: remove gender, telephone, username, position, placeholder, birthdate … - #1126

Merged
bolmsten merged 43 commits into
developfrom
SWAP-4778-View_Only_Profile
Jan 20, 2026
Merged

BREAKING CHANGE: remove gender, telephone, username, position, placeholder, birthdate …#1126
bolmsten merged 43 commits into
developfrom
SWAP-4778-View_Only_Profile

Conversation

@bolmsten

@bolmsten bolmsten commented Jul 14, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR removes redundant user attributes such as gender, telephone, username, position, placeholder, and birthdate in the backend and frontend of the application.

Motivation and Context

The removal of these attributes simplifies the user model and reduces the amount of unnecessary data stored in the database. This change is necessary as these attributes do not contribute to the core functionality of the application.

Changes

  1. Removed gender, telephone, username, position, placeholder, and birthdate columns from the users table in the database.
  2. Updated the UserDataSource interface to reflect the changes in the user model.
  3. Updated the UserDataSourceMock class to remove references to the deleted attributes.
  4. Updated the OAuthAuthorization class to stop populating the removed attributes.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/SWAP-4778

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@bolmsten
bolmsten requested a review from a team as a code owner July 14, 2025 14:30
@bolmsten
bolmsten requested review from EdwardHaynes and removed request for a team July 14, 2025 14:30
@bolmsten bolmsten changed the title feat: remove gender, telephone, username, position, placeholder, birthdate … BREAKING CHANGE: remove gender, telephone, username, position, placeholder, birthdate … Jul 15, 2025
jekabs-karklins
jekabs-karklins reviewed Jul 15, 2025
View reviewed changes
Comment thread apps/backend/db_patches/0204_RemoveUserColulmns.sql
Comment thread apps/backend/src/mutations/UserMutations.ts Outdated
Comment thread apps/frontend/src/components/user/UpdateUserInformation.tsx Outdated
@gnyiri

gnyiri commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

How about removing preferred name as well?

bolmsten and others added 2 commits October 28, 2025 14:25
@bolmsten
Merge branch 'develop' of github.com:UserOfficeProject/user-office-co…
c5b1ddd 
…re into SWAP-4778-View_Only_Profile
@bolmsten @jekabs-karklins
Update apps/frontend/src/components/user/UpdateUserInformation.tsx
2b0e5ca 
Co-authored-by: Jekabs Karklins <58165815+jekabs-karklins@users.noreply.github.com>
@bolmsten

bolmsten commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

How about removing preferred name as well?

I will raise it again with our user officer, the last time she identified this as a field she wants. Can STFC comment here on this?

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

1 similar comment
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

@github-actions
github-actions Bot force-pushed the SWAP-4778-View_Only_Profile branch 2 times, most recently from 4055aff to 18f2f45 Compare November 4, 2025 15:16
@github-actions
github-actions Bot force-pushed the SWAP-4778-View_Only_Profile branch from 18f2f45 to bcac694 Compare November 4, 2025 16:25
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

@github-actions

github-actions Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

@jekabs-karklins jekabs-karklins mentioned this pull request Dec 11, 2025
Merged
2 tasks
simonfernandes
simonfernandes reviewed Dec 16, 2025
View reviewed changes

@simonfernandes simonfernandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolmsten We have moved over to the new particapant selector modal now, so we are all good on removing the EMAIL_INVITE_LEGACY feature 🙂

Comment thread apps/e2e/cypress/e2e/invites.cy.ts
@yoganandaness yoganandaness mentioned this pull request Jan 13, 2026
Closed
2 tasks
@simonfernandes

simonfernandes commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Hi @bolmsten, I've had a look at the tests. I can see in this PR that the only failing file is proposals.cy.ts, and locally in STFC config there is only one failing test within it. It was failing because it was still looking for the old PI selector instead of the new one. I've updated it and it's passing locally now

@bolmsten
bolmsten merged commit 1c1d01d into develop Jan 20, 2026
22 checks passed
@bolmsten
bolmsten deleted the SWAP-4778-View_Only_Profile branch January 20, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonfernandes simonfernandes simonfernandes approved these changes
@jekabs-karklins jekabs-karklins jekabs-karklins approved these changes
@yoganandaness yoganandaness yoganandaness approved these changes
@EdwardHaynes EdwardHaynes Awaiting requested review from EdwardHaynes EdwardHaynes is a code owner automatically assigned from UserOfficeProject/stfc-user-programme
@TCMeldrum TCMeldrum Awaiting requested review from TCMeldrum

Assignees

No one assigned

Labels

review: please

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bolmsten @gnyiri @simonfernandes @jekabs-karklins @TCMeldrum @yoganandaness