feat: assign reviewer rank on mass assignment - #1174
Conversation
Scott-James-Hurley
left a comment
There was a problem hiding this comment.
Looks great. Just a few wee things I noticed
yoganandaness
left a comment
There was a problem hiding this comment.
The Code looks good. When running the app, i noticed few things
If there are 3 reviewers, the rank input does not allow values more than 3. The permissible values are 1,2,3. However, in the mass rank assignment, this is not implemented. It allows any values. It even accepts negative value.
After mass assignment of ranks, when reopening the Dialog, the mass assignment Dialog still appears with empty content, that needs to be resetted.

Can we rename the buttons to "Assign without Rankings", "Assign with Rankings"
Can we show "No Members selected" in the Multi Assignment Dialogue, when there is no Member selected
Save Assignments ----> Submit Mass Assignments(Just a suggestion)
Assign Multiple Ranks ----> Mass Assignments with Ranking(Just a suggestion)
…//github.com/UserOfficeProject/user-office-core into 1128-assign-reviewer-rank-on-mass-assignment
I have added some better vallidion but setting a upper bound on the rank, since all the proposlas could have a different amount of reviewers already assigned then idk what to set a upper bound too.
I have removed the ablity to navigate to the Dialogue when no memebers are selected. |
Closes UserOfficeProject/issue-tracker#1128
Description
This PR introduces a new feature that allows reviewers to be assigned ranks during a mass assignment.
Motivation and Context
The change was necessary because previously, there was no option to assign ranks to multiple reviewers at once, which was inefficient and time-consuming. This feature enhances the user experience by allowing the assignment of reviewer ranks in bulk.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?