Skip to content

feat: assign reviewer rank on mass assignment - #1174

Merged
TCMeldrum merged 14 commits into
developfrom
1128-assign-reviewer-rank-on-mass-assignment
Oct 17, 2025
Merged

feat: assign reviewer rank on mass assignment#1174
TCMeldrum merged 14 commits into
developfrom
1128-assign-reviewer-rank-on-mass-assignment

Conversation

@TCMeldrum

@TCMeldrum TCMeldrum commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Closes UserOfficeProject/issue-tracker#1128

Description

This PR introduces a new feature that allows reviewers to be assigned ranks during a mass assignment.

Motivation and Context

The change was necessary because previously, there was no option to assign ranks to multiple reviewers at once, which was inefficient and time-consuming. This feature enhances the user experience by allowing the assignment of reviewer ranks in bulk.

Changes

  1. Added a 'rank' field in FapDataSource.ts and AssignMembersToFapMutation.ts to store the reviewer's rank.
  2. Updated the FAPs.cy.ts file to test the new functionality of assigning ranks during mass assignment.
  3. Modified AssignFapMemberToProposalModal.tsx to include a button for assigning ranks.
  4. Added model for adding ranks

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum
TCMeldrum requested a review from a team as a code owner September 8, 2025 10:13
@TCMeldrum
TCMeldrum requested review from bashanlam and removed request for a team September 8, 2025 10:13
@TCMeldrum TCMeldrum changed the title 1128 assign reviewer rank on mass assignment feat: assign reviewer rank on mass assignment Sep 8, 2025

@Scott-James-Hurley Scott-James-Hurley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a few wee things I noticed

Comment thread apps/e2e/cypress/e2e/FAPs.cy.ts Outdated
Comment thread apps/frontend/src/components/fap/Proposals/MultiRankAssignmentDialog.tsx Outdated

@yoganandaness yoganandaness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Code looks good. When running the app, i noticed few things

If there are 3 reviewers, the rank input does not allow values more than 3. The permissible values are 1,2,3. However, in the mass rank assignment, this is not implemented. It allows any values. It even accepts negative value.

After mass assignment of ranks, when reopening the Dialog, the mass assignment Dialog still appears with empty content, that needs to be resetted.
Screenshot 2025-10-09 at 14 05 57

Can we rename the buttons to "Assign without Rankings", "Assign with Rankings"

Can we show "No Members selected" in the Multi Assignment Dialogue, when there is no Member selected

Save Assignments ----> Submit Mass Assignments(Just a suggestion)
Assign Multiple Ranks ----> Mass Assignments with Ranking(Just a suggestion)

@TCMeldrum

Copy link
Copy Markdown
Contributor Author

If there are 3 reviewers, the rank input does not allow values more than 3. The permissible values are 1,2,3. However, in the mass rank assignment, this is not implemented. It allows any values. It even accepts negative value.

I have added some better vallidion but setting a upper bound on the rank, since all the proposlas could have a different amount of reviewers already assigned then idk what to set a upper bound too.

Can we show "No Members selected" in the Multi Assignment Dialogue, when there is no Member selected

I have removed the ablity to navigate to the Dialogue when no memebers are selected.

@TCMeldrum

This comment was marked as outdated.

@TCMeldrum
TCMeldrum merged commit 58a2c14 into develop Oct 17, 2025
22 checks passed
@TCMeldrum
TCMeldrum deleted the 1128-assign-reviewer-rank-on-mass-assignment branch October 17, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a FAP secretary, I would like to define who will be 1st and 2nd Reviewers when performing mass-assignment of reviewers to proposals

3 participants