Skip to content

feat: use the new userselect component for pi - #1176

Merged
yoganandaness merged 28 commits into
developfrom
SWAP-4829-use-the-new-userselect-component-for-pi
Oct 15, 2025
Merged

feat: use the new userselect component for pi#1176
yoganandaness merged 28 commits into
developfrom
SWAP-4829-use-the-new-userselect-component-for-pi

Conversation

@jekabs-karklins

@jekabs-karklins jekabs-karklins commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Description

This PR introduces the new userselect component for the "Principal Investigator" field.

Motivation and Context

This change was necessary to keep the user experience consistant for both PI and Co-Proposer selector

Peek 2025-09-09 15-22

Changes

  1. Created new SQL script "Update_email_search_description.sql" to improve the description of the email search feature.
  2. Renamed ProposalParticipant -> PrincipalInvestigator
  3. Renamed Participants -> CoProposers
  4. Renamed InviteUser -> ParticipantSelector
  5. Updated "PrincipalInvestigator.tsx" to use the new ParticipantSelector component
  6. Added two parameters to ParticipantSelector. 'multiple' and 'allowEmailInvites'

How Has This Been Tested?

Added e2e tests

Fixes Jira Issue

https://jira.esss.lu.se/browse/SWAP-4829

@jekabs-karklins jekabs-karklins changed the title Swap 4829 use the new userselect component for pi feat: use the new userselect component for pi Sep 9, 2025
@jekabs-karklins
jekabs-karklins force-pushed the SWAP-4829-use-the-new-userselect-component-for-pi branch from ccee780 to 19bbff5 Compare September 10, 2025 16:03
@jekabs-karklins
jekabs-karklins marked this pull request as ready for review September 18, 2025 15:14
@jekabs-karklins
jekabs-karklins requested a review from a team as a code owner September 18, 2025 15:14
@jekabs-karklins
jekabs-karklins requested review from RasmiaKulan and removed request for a team September 18, 2025 15:14
@simonfernandes

Copy link
Copy Markdown
Contributor

Hi Jekabs, this looks great. We really liked your co-proposer modal and wanted to adopt it, and this is a great change that aligns both designs, so thank you for your work in developing both redesigns!

Just to give you an update on the co-proposer modal usage at STFC for context - we rolled it out to prod but have chosen not to show or use it yet (by keeping EMAIL_INVITE_LEGACY enabled). We are currently in our busiest call so we want to hold off on using it until it's quieter.

Is it possible to hide this PI modal behind a temporary flag too? We are thinking that a) we will need to do some testing/reviewing/tweaking on our side before it goes live and b) it might be nice for us to roll out both co-proposer and PI modal at the same time.

@jekabs-karklins
jekabs-karklins marked this pull request as draft October 2, 2025 12:15
@yoganandaness
yoganandaness self-requested a review October 7, 2025 13:55
@jekabs-karklins

Copy link
Copy Markdown
Contributor Author

Hi Jekabs, this looks great. We really liked your co-proposer modal and wanted to adopt it, and this is a great change that aligns both designs, so thank you for your work in developing both redesigns!

Just to give you an update on the co-proposer modal usage at STFC for context - we rolled it out to prod but have chosen not to show or use it yet (by keeping EMAIL_INVITE_LEGACY enabled). We are currently in our busiest call so we want to hold off on using it until it's quieter.

Is it possible to hide this PI modal behind a temporary flag too? We are thinking that a) we will need to do some testing/reviewing/tweaking on our side before it goes live and b) it might be nice for us to roll out both co-proposer and PI modal at the same time.

Hi @simonfernandes , i have adjusted do that both - co-proposers and pi are behind the feature toggle, now

@simonfernandes

Copy link
Copy Markdown
Contributor

@jekabs-karklins Many thanks for that, I can confirm the feature works as expected for us.

@jekabs-karklins
jekabs-karklins marked this pull request as ready for review October 12, 2025 14:24

@simonfernandes simonfernandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and your refactoring makes these components much easier to understand.

Only small thing I noticed is that when you open the PI modal and click in the text box, it shows a no results message. Same if you remove the current user and search a new user. This feels like a fairly insignificant and hard to notice thing though.

Image

@yoganandaness
yoganandaness enabled auto-merge (squash) October 15, 2025 11:08
@yoganandaness
yoganandaness merged commit 3e1f0ef into develop Oct 15, 2025
36 of 37 checks passed
@yoganandaness
yoganandaness deleted the SWAP-4829-use-the-new-userselect-component-for-pi branch October 15, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants