feat: use the new userselect component for pi - #1176
Conversation
…tandards and best practices
…enhanced user management
…user understanding
… ProposalParticipants component
…d adjust user selection process
ccee780 to
19bbff5
Compare
|
Hi Jekabs, this looks great. We really liked your co-proposer modal and wanted to adopt it, and this is a great change that aligns both designs, so thank you for your work in developing both redesigns! Just to give you an update on the co-proposer modal usage at STFC for context - we rolled it out to prod but have chosen not to show or use it yet (by keeping Is it possible to hide this PI modal behind a temporary flag too? We are thinking that a) we will need to do some testing/reviewing/tweaking on our side before it goes live and b) it might be nice for us to roll out both co-proposer and PI modal at the same time. |
Hi @simonfernandes , i have adjusted do that both - co-proposers and pi are behind the feature toggle, now |
|
@jekabs-karklins Many thanks for that, I can confirm the feature works as expected for us. |
simonfernandes
left a comment
There was a problem hiding this comment.
Looks good to me and your refactoring makes these components much easier to understand.
Only small thing I noticed is that when you open the PI modal and click in the text box, it shows a no results message. Same if you remove the current user and search a new user. This feels like a fairly insignificant and hard to notice thing though.
Description
This PR introduces the new userselect component for the "Principal Investigator" field.
Motivation and Context
This change was necessary to keep the user experience consistant for both PI and Co-Proposer selector
Changes
How Has This Been Tested?
Added e2e tests
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-4829