Skip to content

feat: show tech review template to more roles - #1201

Merged
TCMeldrum merged 7 commits into
developfrom
1474-show-tech-review-templates-to-reviewer
Oct 16, 2025
Merged

feat: show tech review template to more roles#1201
TCMeldrum merged 7 commits into
developfrom
1474-show-tech-review-templates-to-reviewer

Conversation

@TCMeldrum

@TCMeldrum TCMeldrum commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Closes: UserOfficeProject/issue-tracker#1474

Description

This PR expands the visibility of the technical review template to include more roles.

Motivation and Context

Since we now have the templates for tech reviews there might be information capured in them outside of the public comment we might want other roles to see, Backwards compatablity is maintinaed through the new read permissions option that allows parts of the template to rescrited to only certain roles.

Changes

  1. Removed the TechnicalReviewInformation component that was previously only visible to specific roles.
  2. Updated the TechnicalReviewQuestionaryReview component to show the technical review template to additional roles.
  3. Adjusted the conditions to display certain information only to internal users.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@TCMeldrum
TCMeldrum marked this pull request as ready for review October 2, 2025 09:19
@TCMeldrum
TCMeldrum requested a review from a team as a code owner October 2, 2025 09:19
@TCMeldrum
TCMeldrum requested review from mehta-pooja123 and removed request for a team October 2, 2025 09:19
Comment thread apps/frontend/src/components/review/TechnicalReviewQuestionaryReview.tsx Outdated
…Review.tsx

Co-authored-by: Yoganandan Pandiyan <132274772+yoganandaness@users.noreply.github.com>
@TCMeldrum
TCMeldrum enabled auto-merge October 16, 2025 09:10
@TCMeldrum
TCMeldrum disabled auto-merge October 16, 2025 11:07
@TCMeldrum
TCMeldrum enabled auto-merge (squash) October 16, 2025 11:07
@TCMeldrum
TCMeldrum merged commit b0e97e0 into develop Oct 16, 2025
36 of 37 checks passed
@TCMeldrum
TCMeldrum deleted the 1474-show-tech-review-templates-to-reviewer branch October 16, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the tech review templates to FAP reviewers

3 participants