fix: add more context to readiness check - #1218
Merged
Merged
Conversation
mutambaraf
requested review from
a team,
William-Edwards-STFC and
bolmsten
and removed request for
a team
October 10, 2025 15:23
deepaksftc
reviewed
Oct 13, 2025
deepaksftc
approved these changes
Oct 13, 2025
yoganandaness
requested changes
Oct 22, 2025
| .catch((e) => { | ||
| logger.logException('Readiness check failed', e); | ||
| res.status(500).end(); | ||
| await baseContext.queries.system.connectivityCheck().then((success) => { |
Contributor
There was a problem hiding this comment.
Do we want to have then, catch, if we are going to use await?
Contributor
|
@mutambaraf I noticed that, we are querying settings table for health check. Could we change it to |
yoganandaness
approved these changes
Oct 22, 2025
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
Looks great @mutambaraf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
/readinesshealth check to provide dependency information and also improve how we send back HTTP status codes.Motivation and Context
How Has This Been Tested
Manual
Fixes
Changes
Depends on
Tests included/Docs Updated?