fix: key proposalPKey added to the event handler to eliminate error - #1225
Closed
yoganandaness wants to merge 2 commits into
Closed
fix: key proposalPKey added to the event handler to eliminate error#1225yoganandaness wants to merge 2 commits into
yoganandaness wants to merge 2 commits into
Conversation
…nd facilitate saving of data in event logs
yoganandaness
requested review from
TCMeldrum,
janosbabik and
mehta-pooja123
and removed request for
a team
October 14, 2025 14:27
…for-event-logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
key proposalPKey added to the event handler to eliminate error and facilitate saving of data in event logs
Motivation and Context
The required key proposalPKey was not passed to the logging for the event PROPOSAL_CO_PROPOSER_INVITE_EMAIL_SENT thereby resulting in following error
`Error was detected!
Context: {"exception":{"name":"TypeError","message":"Cannot read properties of undefined (reading 'toString')","stack":"TypeError: Cannot read properties of undefined (reading 'toString')\n at /home/node/app/build/src/eventHandlers/logging.js:188:111\n at Generator.next ()\n at /home/node/app/build/src/eventHandlers/logging.js:8:71\n at new Promise ()\n at __awaiter (/home/node/app/build/src/eventHandlers/logging.js:4:12)\n at loggingHandler (/home/node/app/build/src/eventHandlers/logging.js:27:16)\n at EventBus. (/home/node/app/build/src/events/eventBus.js:23:27)\n at Generator.next ()\n at fulfilled (/home/node/app/build/src/events/eventBus.js:5:58)\n at process.processTicksAndRejections (node:internal/process/task_queues:105:5)"}}
Platform: duo-backend
Environment: staging
Title: Error handling logs for event PROPOSAL_CO_PROPOSER_INVITES_UPDATED
Source: duo-backend-staging-6b99d9c66c-rmgff
Timestamp: 2025-10-14T14:05:33.508Z
Visit graylog for more information: https://it-graylog.esss.lu.se/`
How Has This Been Tested
Tested locally
Fixes
Changes
Added proposalPKey as parameter when sending out the event for PROPOSAL_CO_PROPOSER_INVITE_EMAIL_SENT
Depends on
Tests included/Docs Updated?