feat: legacy fap proposals page - #1226
Merged
Merged
Conversation
TCMeldrum
marked this pull request as ready for review
October 16, 2025 14:58
TCMeldrum
requested review from
a team,
William-Edwards-STFC,
mehta-pooja123 and
yoganandaness
and removed request for
a team and
mehta-pooja123
October 16, 2025 14:58
yoganandaness
requested changes
Oct 17, 2025
yoganandaness
left a comment
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me except the console logging. In addition, it would be good to see a video or a screenshot of how it had come up.
| const currentCall = call ? parseInt(call) : null; | ||
|
|
||
| // If the selected call is not valid, remove it from the URL | ||
| console.log(calls); |
Contributor
There was a problem hiding this comment.
Should we remove this?
yoganandaness
approved these changes
Oct 17, 2025
William-Edwards-STFC
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1059
Description
This PR introduces the functionality to view legacy FAP proposals.
Motivation and Context
This change is required to allow users to access and view legacy FAP proposals, which was not possible in the previous version.
Changes
getLegacyFapProposalshas been added to theFapDataSourceinterface and implemented in the relevant classes.FapQueriesclass, a conditional check has been added to call eithergetLegacyFapProposalsorgetFapProposalsbased on thelegacyflag.legacyhas been added to thegetFapProposalsmethod in theFapQueryclass.Video works on chrome but not firefox lol
Recording.10-17.at.10.14.webm
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?