Skip to content

feat: update cypress image - #1227

Merged
mutambaraf merged 9 commits into
developfrom
1454-update-cypress-image
Oct 24, 2025
Merged

feat: update cypress image#1227
mutambaraf merged 9 commits into
developfrom
1454-update-cypress-image

Conversation

@mutambaraf

@mutambaraf mutambaraf commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Closes: UserOfficeProject/issue-tracker#1454

Description

This pr upgrading the cypress docker image and cypress version to 15.4 . Additionally, it includes small changes to existing cypress tests that were failing due to React Flow where the parent edge element reports an effective width of zero, causing the standard click to time out, we now just check if element exist we bypass the strict visibility check for the edge.

Motivation and Context

How Has This Been Tested

Cypress tests

Fixes

Changes

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@mutambaraf
mutambaraf marked this pull request as ready for review October 22, 2025 09:38
@mutambaraf
mutambaraf requested a review from a team as a code owner October 22, 2025 09:38
@mutambaraf
mutambaraf requested review from a team, William-Edwards-STFC and martin-trajanovski and removed request for a team October 22, 2025 09:38
@mutambaraf
mutambaraf requested review from a team and bolmsten and removed request for a team October 22, 2025 10:32

@simonfernandes simonfernandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but do we want 15.5.0 which came out yesterday?

@mutambaraf

mutambaraf commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Looks good but do we want 15.5.0 which came out yesterday?

I have tried to bump it up but having some issues with the linter .
TS2345: Argument of type 'import("/e2e/user-office-core-e2e/node_modules/graphql-request/build/esm/index").GraphQLClient' is not assignable to parameter of type 'import("/e2e/frontend/node_modules/graphql-request/build/esm/index").GraphQLClient'. Types have separate declarations of a private property 'url'. Which l think is related to this issue . I am happy to leave the upgrade at version 15.4 then bump it again when we fix some of the linting issues being caused by graphql-request

@bolmsten
bolmsten requested review from jekabs-karklins and removed request for bolmsten and martin-trajanovski October 23, 2025 09:52
@mutambaraf
mutambaraf merged commit 9e957a1 into develop Oct 24, 2025
36 of 37 checks passed
@mutambaraf
mutambaraf deleted the 1454-update-cypress-image branch October 24, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cypress docker image

4 participants