fix: data refreshing on first render is restricted to avoid multiple api calls and optimised the handling of search query params

[yoganandaness]

Description

The Proposal table have few usability issues

1. Sorting the column resets the page size and page number
2. Page size is not persisting in query params, so refreshing the page forgets the page size
3. Proposal Modal on refreshing does not work sometimes, as the page size and page number is lost
4. Avoid fetching multiple times

The above have been fixed by ensuring that the refreshing of table happens only on filter changes and not on first rendering. Also the setting of search params have been optimised in such a way that it does not resets the other ones

Motivation and Context

Improve the usability of the the Proposal Table and ensuing persistence of the query params, so that the page refresh shows the same result

How Has This Been Tested

Manually

Fixes

Changes

In Proposal Table component, the search params handling and the refreshing data restriction has been done

Depends on

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[janosbabik]

Hi @yoganandaness !
It looks good, just a small request from my side.

[janosbabik]

if we really need to track it, can we use useRef instead of useState?

[yoganandaness]

Sure

[janosbabik]

I think the original implementation was not correct, using isMounted here doesn’t make sense, it’s being used incorrectly.

We can simplify it like this:

useEffect(() => {
  if (isFirstRender.current) {
    isFirstRender.current = false;
    return;
  }
  
  refreshTableData();
}, [proposalFilter]);

[yoganandaness]

Nice point. Yes, we dont need the isMounted