fix: remove error log for no co proposers in email - #1236
Merged
bolmsten merged 5 commits intoOct 29, 2025
Conversation
ellen-wright
changed the title
Scott-James-Hurley
approved these changes
Oct 24, 2025
bolmsten
requested changes
Oct 28, 2025
| if (!recipientsWithData.length) { | ||
| if (!recipientsWithData.length && messageType != 'CoProposer') { | ||
| logger.logInfo('Could not send email(s) because there are no recipients.', { | ||
| recipientsWithData, |
Contributor
There was a problem hiding this comment.
Do we need this log at all? And if so would not recipientsWithData always be an empty array as that is the if statement?
…ttps://github.com/UserOfficeProject/user-office-core into 1295-Change-log-level-for-no-recipients-email-error
bolmsten
approved these changes
Oct 29, 2025
bolmsten
deleted the
1295-Change-log-level-for-no-recipients-email-error
branch
October 29, 2025 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #1295
Description
Motivation and Context
There was a repeated error log that triggered when an email was sent with no co-proposers that has been filling up the logs.
Changes
I have added a check so the error is not triggered if there are no co-proposers as this is a valid use case
Depends on
Tests included/Docs Updated?