From 1676a8a54fdb2739a2e688244f1236328222b9fc Mon Sep 17 00:00:00 2001
From: Ellen Wright <ellen.wright@stfc.ac.uk>
Date: Wed, 22 Oct 2025 12:34:30 +0100
Subject: [PATCH 1/2] Remove error log for no co proposers in email

---
 apps/backend/src/statusActionEngine/emailActionHandler.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/apps/backend/src/statusActionEngine/emailActionHandler.ts b/apps/backend/src/statusActionEngine/emailActionHandler.ts
index b22b9df674..8a54e65c7a 100644
--- a/apps/backend/src/statusActionEngine/emailActionHandler.ts
+++ b/apps/backend/src/statusActionEngine/emailActionHandler.ts
@@ -139,7 +139,8 @@ export const emailStatusActionRecipient = async (
         successfulMessage,
         failMessage,
         templateMessage,
-        loggedInUserId
+        loggedInUserId,
+        'CoProposer'
       );
 
       break;
@@ -424,7 +425,8 @@ const sendMail = async (
   successfulMessage: string,
   failMessage: string,
   templateMessage: string,
-  loggedInUserId?: number | null
+  loggedInUserId?: number | null,
+  messageType?: string
 ) => {
   const mailService = container.resolve<MailService>(Tokens.MailService);
   const loggingHandler = container.resolve<
@@ -434,7 +436,7 @@ const sendMail = async (
     (event: ApplicationEvent) => Promise<void>
   >(Tokens.EmailEventHandler);
 
-  if (!recipientsWithData.length) {
+  if (!recipientsWithData.length && messageType != 'CoProposer') {
     logger.logInfo('Could not send email(s) because there are no recipients.', {
       recipientsWithData,
     });

From ab6ad8a2eea47ea67e43f66ee6449ddd55997bde Mon Sep 17 00:00:00 2001
From: Ellen Wright <ellen.wright@stfc.ac.uk>
Date: Wed, 29 Oct 2025 09:17:03 +0000
Subject: [PATCH 2/2] Do not send emails with no coproposers

---
 .../statusActionEngine/emailActionHandler.ts  | 36 +++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/apps/backend/src/statusActionEngine/emailActionHandler.ts b/apps/backend/src/statusActionEngine/emailActionHandler.ts
index 8a54e65c7a..ccf5968b61 100644
--- a/apps/backend/src/statusActionEngine/emailActionHandler.ts
+++ b/apps/backend/src/statusActionEngine/emailActionHandler.ts
@@ -127,21 +127,22 @@ export const emailStatusActionRecipient = async (
         proposals,
         recipientWithTemplate
       );
-      await sendMail(
-        CPs,
-        statusActionLogger({
-          connectionId: statusAction.connectionId,
-          actionId: statusAction.actionId,
-          statusActionsLogId,
-          emailStatusActionRecipient: EmailStatusActionRecipients.CO_PROPOSERS,
-          proposalPks,
-        }),
-        successfulMessage,
-        failMessage,
-        templateMessage,
-        loggedInUserId,
-        'CoProposer'
-      );
+      CPs.length &&
+        (await sendMail(
+          CPs,
+          statusActionLogger({
+            connectionId: statusAction.connectionId,
+            actionId: statusAction.actionId,
+            statusActionsLogId,
+            emailStatusActionRecipient:
+              EmailStatusActionRecipients.CO_PROPOSERS,
+            proposalPks,
+          }),
+          successfulMessage,
+          failMessage,
+          templateMessage,
+          loggedInUserId
+        ));
 
       break;
     }
@@ -425,8 +426,7 @@ const sendMail = async (
   successfulMessage: string,
   failMessage: string,
   templateMessage: string,
-  loggedInUserId?: number | null,
-  messageType?: string
+  loggedInUserId?: number | null
 ) => {
   const mailService = container.resolve<MailService>(Tokens.MailService);
   const loggingHandler = container.resolve<
@@ -436,7 +436,7 @@ const sendMail = async (
     (event: ApplicationEvent) => Promise<void>
   >(Tokens.EmailEventHandler);
 
-  if (!recipientsWithData.length && messageType != 'CoProposer') {
+  if (!recipientsWithData.length) {
     logger.logInfo('Could not send email(s) because there are no recipients.', {
       recipientsWithData,
     });