fix: usage of outdated invite object resulted in PI not being able receive notification on invite accept - #1245
Merged
Merged
Conversation
…o receive notification on invite accept
yoganandaness
requested review from
janosbabik and
mutambaraf
and removed request for
a team
October 31, 2025 12:44
mutambaraf
approved these changes
Oct 31, 2025
yoganandaness
enabled auto-merge (squash)
October 31, 2025 13:15
janosbabik
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a co-proposer invite has been accepted, an event is triggered that sends out email notification to the Principal Investigator. Since, the outdated invite is being used by the event, that does not contain the claimedByUserId, the event fails with the error "No claimer found when trying to send invite accepted email". To fix this, update the invite first with the claimedByUserId and pass it to the event.
Motivation and Context
Fix Invite Accepted Notification to PI
How Has This Been Tested
Manually and attached tests.
Fixes
Invite accept Email notification to PI
Changes
Ensuring that the updated invite object is being used rather than the outdated one
Depends on
Tests included/Docs Updated?