Skip to content

chore: release 13/11/25 merge back - #1262

Closed
Scott-James-Hurley wants to merge 5 commits into
developfrom
master
Closed

chore: release 13/11/25 merge back#1262
Scott-James-Hurley wants to merge 5 commits into
developfrom
master

Conversation

@Scott-James-Hurley

@Scott-James-Hurley Scott-James-Hurley commented Nov 17, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This pull request introduces a new event handler for data access user updates in the message broker.

Motivation and Context

This change is required to ensure that when data access users are updated, a DATA_ACCESS_USERS_UPDATED event is appropriately dispatched and handled, thereby keeping the system state consistent and up-to-date.

Changes

  1. A new case for DATA_ACCESS_USERS_UPDATED event is added in the message broker.
  2. For this event, the proposal associated with the event is fetched, and a message is prepared using getProposalMessageData.
  3. This message is then sent to the RabbitMQ exchange, notifying all relevant parties about the update in data access users.

This change ensures that all updates related to data access users are appropriately propagated through the system, maintaining data integrity and consistency.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

mutambaraf and others added 3 commits October 22, 2025 16:34
@mutambaraf @yoganandaness
@jekabs-karklins jekabskarklins @simonfernandes @TCMeldrum @gnyiri @dependabot @github-actions @ellen-wright @bashanlam @deepaksftc Gergely Nyiri
Release 23/10/2025 (#1237)
0f7dd4b 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Yoganandan Pandiyan <yoganandan.pandiyan@ess.eu>
Co-authored-by: Yoganandan Pandiyan <132274772+yoganandaness@users.noreply.github.com>
Co-authored-by: Jekabs Karklins <58165815+jekabs-karklins@users.noreply.github.com>
Co-authored-by: jekabskarklins <jekabs.karklins@ess.eu>
Co-authored-by: Simon Fernandes <simon.fernandes@stfc.ac.uk>
Co-authored-by: Thomas Cottee Meldrum <81559866+TCMeldrum@users.noreply.github.com>
Co-authored-by: Gergely Nyiri <gergely.nyiri@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ellen Wright <144028998+ellen-wright@users.noreply.github.com>
Co-authored-by: Chi Kai Lam <chi-kai.lam@stfc.ac.uk>
Co-authored-by: Deepak Jaison <149392207+deepaksftc@users.noreply.github.com>
Co-authored-by: Gergely Nyiri <gergely.nyiri@eli-alps.hu>
Co-authored-by: Chi Kai Lam <114708346+bashanlam@users.noreply.github.com>
@Scott-James-Hurley
release 12-11-25 fix merge conflicts
5f6a0b1
@Scott-James-Hurley
Release 2025 11 13 (#1258)
10d069d
@Scott-James-Hurley
Scott-James-Hurley requested a review from a team as a code owner November 17, 2025 10:21
@Scott-James-Hurley
Scott-James-Hurley requested review from simonfernandes and removed request for a team November 17, 2025 10:21
janosbabik
janosbabik reviewed Nov 17, 2025
View reviewed changes

@janosbabik janosbabik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Scott-James-Hurley , I think when you created the last release, during the conflict resolution the Event.DATA_ACCESS_USERS_UPDATED section became duplicated.
So when this is merged back, it should be fixed in the dev branch.
5f6a0b1
Line: 399 and 412

@Scott-James-Hurley

Scott-James-Hurley commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @Scott-James-Hurley , I think when you created the last release, during the conflict resolution the Event.DATA_ACCESS_USERS_UPDATED section became duplicated. So when this is merged back, it should be fixed in the dev branch. 5f6a0b1 Line: 399 and 412

Thanks, I'll put in a PR for that after this is merged.

@Scott-James-Hurley Scott-James-Hurley changed the title Release 13/11/25 Merge Back chore: release 13/11/25 merge back Nov 19, 2025
@github-actions

github-actions Bot commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

1 similar comment
@github-actions

github-actions Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

⚠️ Automatic rebase failed due to conflicts. Please rebase manually.

@Scott-James-Hurley

Scott-James-Hurley commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

I'm going to close this pr and try opening another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonfernandes simonfernandes simonfernandes approved these changes
@janosbabik janosbabik janosbabik approved these changes

Assignees

No one assigned

Labels

review: please

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Scott-James-Hurley @simonfernandes @janosbabik @mutambaraf @TCMeldrum