From df9b481e3e8e6f1d6a86a6c6539121ec2ee3fc0a Mon Sep 17 00:00:00 2001 From: Thomas Cottee Meldrum Date: Mon, 17 Nov 2025 14:51:15 +0000 Subject: [PATCH 1/2] fix: make tech review boxes description more detailed --- ...estionaryComponentTechnicalReviewBasis.tsx | 29 ++++++++++++++----- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx b/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx index 5bb5a51f28..db95673155 100644 --- a/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx +++ b/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx @@ -20,6 +20,7 @@ import { useCheckAccess } from 'hooks/common/useCheckAccess'; import { SubmitActionDependencyContainer } from 'hooks/questionary/useSubmitActions'; import { TechnicalReviewSubmissionState } from 'models/questionary/technicalReview/TechnicalReviewSubmissionState'; import { Option } from 'utils/utilTypes'; +import { useTranslation } from 'react-i18next'; function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) { const { @@ -28,7 +29,7 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) { }, formikProps, } = props; - + const { t } = useTranslation(); const theme = useTheme(); const { state, dispatch } = useContext( QuestionaryContext @@ -156,8 +157,13 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) { isInstrumentScientist || fapSecOrChairCanEdit) && ( - - Internal comment + + Internal comment - To only be seen by other technical + reviewers {/* NOTE: We are using Editor directly instead of FormikUICustomEditor with Formik Field component. This is because FormikUICustomEditor is not updated properly when we set form field onEditorChange. @@ -209,8 +215,13 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) { isInstrumentScientist || fapSecOrChairCanEdit) && ( - - Internal documents + + Internal documents - To only be seen by other technical + reviewers )} - - Comments for the review panel + + {`Comments be seen by the ${t('FAP')} panels`} Date: Mon, 17 Nov 2025 15:20:56 +0000 Subject: [PATCH 2/2] fix lint --- .../QuestionaryComponentTechnicalReviewBasis.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx b/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx index db95673155..c68066cdb4 100644 --- a/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx +++ b/apps/frontend/src/components/questionary/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx @@ -1,6 +1,7 @@ import { Box, CssBaseline, Grid, InputLabel, useTheme } from '@mui/material'; import { Field } from 'formik'; import React, { ChangeEvent, useContext, useEffect, useState } from 'react'; +import { useTranslation } from 'react-i18next'; import { FileUploadComponent, @@ -20,7 +21,6 @@ import { useCheckAccess } from 'hooks/common/useCheckAccess'; import { SubmitActionDependencyContainer } from 'hooks/questionary/useSubmitActions'; import { TechnicalReviewSubmissionState } from 'models/questionary/technicalReview/TechnicalReviewSubmissionState'; import { Option } from 'utils/utilTypes'; -import { useTranslation } from 'react-i18next'; function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) { const {