Skip to content

fix: make tech review boxes description more detailed #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TCMeldrum merged 5 commits into from
Jan 23, 2026
Merged

fix: make tech review boxes description more detailed #1263

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df9b481
fix: make tech review boxes description more detailed
TCMeldrum Nov 17, 2025
3098d69
fix lint
TCMeldrum Nov 17, 2025
e9e51eb
Merge branch 'develop' into 1495-tech-review-box-description
janosbabik Nov 27, 2025
f5d1fc9
Merge branch 'develop' into 1495-tech-review-box-description
TCMeldrum Jan 12, 2026
26b40d8
Merge branch 'develop' into 1495-tech-review-box-description
TCMeldrum Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions ...y/questionaryComponents/TechnicalReviewBasis/QuestionaryComponentTechnicalReviewBasis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Box, CssBaseline, Grid, InputLabel, useTheme } from '@mui/material';
import { Field } from 'formik';
import React, { ChangeEvent, useContext, useEffect, useState } from 'react';
import { useTranslation } from 'react-i18next';

import {
FileUploadComponent,
Expand Down Expand Up @@ -28,7 +29,7 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) {
},
formikProps,
} = props;

const { t } = useTranslation();
const theme = useTheme();
const { state, dispatch } = useContext(
QuestionaryContext
Expand Down Expand Up @@ -156,8 +157,13 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) {
isInstrumentScientist ||
fapSecOrChairCanEdit) && (
<Grid item xs={12}>
<InputLabel htmlFor="comment" shrink margin="dense">
Internal comment
<InputLabel
htmlFor="comment"
margin="dense"
sx={{ fontWeight: 'bold', color: 'text.primary' }}
>
Internal comment - To only be seen by other technical
reviewers
</InputLabel>
{/* NOTE: We are using Editor directly instead of FormikUICustomEditor with Formik Field component.
This is because FormikUICustomEditor is not updated properly when we set form field onEditorChange.
Expand Down Expand Up @@ -209,8 +215,13 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) {
isInstrumentScientist ||
fapSecOrChairCanEdit) && (
<Grid item xs={12}>
<InputLabel htmlFor="comment" shrink margin="dense">
Internal documents
<InputLabel
htmlFor="comment"
margin="dense"
sx={{ fontWeight: 'bold', color: 'text.primary' }}
>
Internal documents - To only be seen by other technical
reviewers
</InputLabel>
<FileUploadComponent
maxFiles={5}
Expand Down Expand Up @@ -241,8 +252,12 @@ function QuestionaryComponentTechnicalReviewBasis(props: BasicComponentProps) {
</Grid>
)}
<Grid item xs={12}>
<InputLabel htmlFor="publicComment" shrink margin="dense">
Comments for the review panel
<InputLabel
htmlFor="publicComment"
margin="dense"
sx={{ fontWeight: 'bold', color: 'text.primary' }}
>
{`Comments be seen by the ${t('FAP')} panels`}
</InputLabel>
<Editor
id="publicComment"
Expand Down
Loading