fix: remove bad orderby in getUsers - #1265
Merged
Merged
Conversation
bolmsten
requested review from
William-Edwards-STFC and
yoganandaness
and removed request for
a team
November 18, 2025 13:36
yoganandaness
approved these changes
Nov 18, 2025
TCMeldrum
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a redundant
orderByclause in thegetUsersfunction.Motivation and Context
The
orderByclause was causing incorrect user sorting. By removing this clause, we ensure that users are fetched in their correct order, improving data accuracy and usability.Changes
orderByclause from thegetUsersfunction inUserDataSource.ts. This change eliminates incorrect sorting of users based on theiruser_id.