Skip to content

fix: only show active fap reviews in ProposalTableReviewer - #1269

Merged
TCMeldrum merged 4 commits into
developfrom
1497-fap-review-page-shows-old-proposals
Dec 2, 2025
Merged

fix: only show active fap reviews in ProposalTableReviewer#1269
TCMeldrum merged 4 commits into
developfrom
1497-fap-review-page-shows-old-proposals

Conversation

@TCMeldrum

@TCMeldrum TCMeldrum commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Closes UserOfficeProject/issue-tracker#1497

Description

This PR ensures that only active FAP reviews are shown in the ProposalTableReviewer.

Motivation and Context

This change was required to avoid confusion and to improve user experience by not displaying reviews that are no longer active or relevant. It helps to keep the UI clean and focused on the current tasks.

Changes

  1. Introduced a new optional parameter 'active' in ReviewDataSource and its implementations. This parameter is used to filter out inactive FAP reviews.
  2. Updated UserResolver to accept the 'active' parameter and pass it to the review data source.
  3. Updated ProposalTableReviewer component to pass 'active: true' when fetching user data. This ensures that only active reviews will be fetched and displayed.
  4. Added a new test case in FAPs.cy.ts to check that only proposals from calls with active review periods are visible.

How Has This Been Tested?

Fixes Jira Issue

https://jira.esss.lu.se/browse/

Depends On

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@github-actions
github-actions Bot force-pushed the 1497-fap-review-page-shows-old-proposals branch from e22ab69 to fe5a812 Compare November 21, 2025 10:46
@TCMeldrum
TCMeldrum marked this pull request as ready for review November 21, 2025 10:49
@TCMeldrum
TCMeldrum requested a review from a team as a code owner November 21, 2025 10:49
@TCMeldrum
TCMeldrum requested review from Scott-James-Hurley and removed request for a team November 21, 2025 10:49
@janosbabik
janosbabik self-requested a review November 24, 2025 10:48
@github-actions
github-actions Bot force-pushed the 1497-fap-review-page-shows-old-proposals branch from 7a7fc04 to 183b2e0 Compare November 25, 2025 16:22
@TCMeldrum
TCMeldrum merged commit 268574c into develop Dec 2, 2025
22 checks passed
@TCMeldrum
TCMeldrum deleted the 1497-fap-review-page-shows-old-proposals branch December 2, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProposalTableReviewer shows reviews for round not in FAP review

3 participants