fix: refactor institution handling in user authorization and mutation - #1289
Merged
Conversation
jekabs-karklins
requested review from
Scott-James-Hurley
and removed request for
a team
December 10, 2025 10:46
jekabs-karklins
marked this pull request as draft
December 10, 2025 12:24
jekabs-karklins
changed the title
…gging created institution ID
…nd for user upsert
jekabs-karklins
changed the title
added 3 commits
February 24, 2026 13:45
jekabs-karklins
changed the title
jekabs-karklins
commented
Feb 24, 2026
added 3 commits
February 24, 2026 16:22
added 4 commits
March 2, 2026 19:09
Contributor
Author
|
Hi, @Scott-James-Hurley |
Contributor
Author
|
@yoganandaness I have addressed the comments, since we are blocking the IAM team this would be nice to get merged so we can ublock them |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yoganandaness
requested review from
yoga-teachedison
and removed request for
yoga-teachedison
March 11, 2026 17:03
yoganandaness
approved these changes
Mar 11, 2026
yoganandaness
left a comment
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
- Adding ROR_API_URL to env.example is good for documentation purpose.
- Copilot Comments on Empty RoR ID handling was interesting
- Also adding a brief about this in Documentation will be great(if applicable).
Otherwise looks good. Approving this.
yoganandaness
requested review from
yoga-teachedison
and removed request for
yoga-teachedison
March 11, 2026 17:05
added 3 commits
March 11, 2026 18:59
…rOfficeProject/user-office-core into SWAP-5157-update-upsertuserbyoidcsub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the way
institutionis defined when calling upserUserByOidcMotivation and Context
This change allows to call upserUserByOidc and specify institution in two ways
Either specifying
RorIdor
{institutionName: string, institutionCountry: string}Changes
getOrCreateUserInstitutionmethod inOAuthAuthorizationto accept different types of input (ROR ID, manual input, institution ID), and split into smaller, more specific methods.getOrCreateUserInstitutionmethod inStfcUserAuthorizationto match the new input type.getOrCreateUserInstitutionmethod inUserAuthorizationto match the new input type.How Has This Been Tested
Unit tests have been added and updated and run to ensure the changes work as expected. Additionally, manual testing has been performed to verify correct functionality in a live environment.
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-5157