feat: improve ProposalQuestionaryReview ui

[jekabs-karklins]

Description

This PR improves the UI formatting and information in Proposal Questionary Review page

Motivation and Context

We got feedback that user were not getting good overview in the review page when proposal is submitted/is about to be submitted.

Changes

1. A new UserList component has been created to display a list of users with the ability to show more or less. The feedback we got is that if many users are on the proposal then it gets hard to read.
2. Data access users field has been added to the proposal type at the backend.

How Has This Been Tested?

Locally and with E2E tests test.

Fixes Jira Issue

https://jira.esss.lu.se/browse/SWAP-5165

Depends On

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[gnyiri]

A question: will the new UI render all co-proposers? As far as I remember, only the first 10 co-proposers are rendered currently.

[jekabs-karklins]

A question: will the new UI render all co-proposers? As far as I remember, only the first 10 co-proposers are rendered currently.

I just tested and you are right that it renders only first 10 in the UI where you add co-proposers

However the Proposal review page all of the members are listed.

Thank you for pointing it out, I was not aware about it. Do you know if there should not be more than 10 co-proposers? If yes then I guess we should enforce it, because now you can keep adding they will just not be seen and cant be easily removed. Otherwise we should have a paged list.

[jekabs-karklins]

@bashanlam Could you take a look at this, thanks :)

[gnyiri]

A question: will the new UI render all co-proposers? As far as I remember, only the first 10 co-proposers are rendered currently.

I just tested and you are right that it renders only first 10 in the UI where you add co-proposers

However the Proposal review page all of the members are listed.

Thank you for pointing it out, I was not aware about it. Do you know if there should not be more than 10 co-proposers? If yes then I guess we should enforce it, because now you can keep adding they will just not be seen and cant be easily removed. Otherwise we should have a paged list.

At ELI we have some proposals with more than 10 co-proposers so I guess that we should make it possible. We can add the paging in a later PR otherwise.

[jekabs-karklins]

A question: will the new UI render all co-proposers? As far as I remember, only the first 10 co-proposers are rendered currently.

I just tested and you are right that it renders only first 10 in the UI where you add co-proposers
However the Proposal review page all of the members are listed.
Thank you for pointing it out, I was not aware about it. Do you know if there should not be more than 10 co-proposers? If yes then I guess we should enforce it, because now you can keep adding they will just not be seen and cant be easily removed. Otherwise we should have a paged list.

At ELI we have some proposals with more than 10 co-proposers so I guess that we should make it possible. We can add the paging in a later PR otherwise.

@yoganandaness has added the support for more than 10 users with this PR
#1304

So now all users are accessible in both places - when defining co-proposers and also in the review step

[yoganandaness]

A question: will the new UI render all co-proposers? As far as I remember, only the first 10 co-proposers are rendered currently.

@gnyiri This was solved in #1304